From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53174C43334 for ; Wed, 8 Jun 2022 03:47:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4ED66B0071; Tue, 7 Jun 2022 23:47:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD6D16B0073; Tue, 7 Jun 2022 23:47:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B51296B0074; Tue, 7 Jun 2022 23:47:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A235E6B0071 for ; Tue, 7 Jun 2022 23:47:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 7856B80638 for ; Wed, 8 Jun 2022 03:47:24 +0000 (UTC) X-FDA: 79553683608.28.B438B05 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 0EC5440005 for ; Wed, 8 Jun 2022 03:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654660043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S1W4hgx8Hu6HctQFGvInxvOPdJHknH/VauE9079NO9c=; b=d0NGtSR/GbL7axpeE8wfXj/xToBVVoAdd3zjKPxA1bdSa7N1lYj8t4h1gBFmUgNq5V05+M KNGoYU4xsybEX9tjMfzk+obpnO1/+VAALeYYI4LSzsEQlAA71T/+qkpB1F9LfuW1n0SnQi YRkrru1S0x1FkeKkOomddSbaXBJl16I= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-380-iuJJXqDKPlupan0skIUoTw-1; Tue, 07 Jun 2022 23:47:18 -0400 X-MC-Unique: iuJJXqDKPlupan0skIUoTw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD09D1C0CE7A; Wed, 8 Jun 2022 03:47:17 +0000 (UTC) Received: from localhost (ovpn-12-81.pek2.redhat.com [10.72.12.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1F7F2166B26; Wed, 8 Jun 2022 03:47:16 +0000 (UTC) Date: Wed, 8 Jun 2022 11:47:12 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 4/5] mm/vmalloc: Extend __find_vmap_area() with one more argument Message-ID: References: <20220607093449.3100-1-urezki@gmail.com> <20220607093449.3100-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607093449.3100-5-urezki@gmail.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Stat-Signature: 18a7xxf1o96duotqfnsc74ykmwtxfwdo Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="d0NGtSR/"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of bhe@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=bhe@redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0EC5440005 X-HE-Tag: 1654660043-251378 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/07/22 at 11:34am, Uladzislau Rezki (Sony) wrote: > __find_vmap_area() finds a "vmap_area" based on passed address. > It scan the specific "vmap_area_root" rb-tree. Extend the function > with one extra argument, so any tree can be specified where the > search has to be done. > > There is no functional change as a result of this patch. LGTM, Reviewed-by: Baoquan He > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 82771e555273..b60385101897 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -814,9 +814,9 @@ static struct vmap_area *find_vmap_area_exceed_addr(unsigned long addr) > return va; > } > > -static struct vmap_area *__find_vmap_area(unsigned long addr) > +static struct vmap_area *__find_vmap_area(unsigned long addr, struct rb_root *root) > { > - struct rb_node *n = vmap_area_root.rb_node; > + struct rb_node *n = root->rb_node; > > addr = (unsigned long)kasan_reset_tag((void *)addr); > > @@ -1840,7 +1840,7 @@ static struct vmap_area *find_vmap_area(unsigned long addr) > struct vmap_area *va; > > spin_lock(&vmap_area_lock); > - va = __find_vmap_area(addr); > + va = __find_vmap_area(addr, &vmap_area_root); > spin_unlock(&vmap_area_lock); > > return va; > @@ -2582,7 +2582,7 @@ struct vm_struct *remove_vm_area(const void *addr) > might_sleep(); > > spin_lock(&vmap_area_lock); > - va = __find_vmap_area((unsigned long)addr); > + va = __find_vmap_area((unsigned long)addr, &vmap_area_root); > if (va && va->vm) { > struct vm_struct *vm = va->vm; > > -- > 2.30.2 > >