From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7ADC433EF for ; Sun, 19 Jun 2022 19:49:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C43376B0071; Sun, 19 Jun 2022 15:49:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFDD16B0072; Sun, 19 Jun 2022 15:49:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE1D46B0073; Sun, 19 Jun 2022 15:49:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F16C6B0071 for ; Sun, 19 Jun 2022 15:49:33 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 60313120B50 for ; Sun, 19 Jun 2022 19:49:33 +0000 (UTC) X-FDA: 79596025026.31.6B77E62 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf16.hostedemail.com (Postfix) with ESMTP id C780B18000F for ; Sun, 19 Jun 2022 19:49:32 +0000 (UTC) Date: Sun, 19 Jun 2022 12:49:21 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1655668170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XTYDF9D1xRBqvEkIY/ONzMnvR1i6T1Y9BCxsJP7NEik=; b=iL6YfmMAG2p0X/5gbwURAp46tCZ3JVCg5XQj8j0kJcfdzd8GpZcwIqK+rrSh2+DfTLgrS/ fHu0/cvEEvB2i/JDQmg9tGfO7fv+/SvuWHRs+6CJwMgnFSjnJifTMszZdW4NvhhpIw0Y0p AqIgK1bpEvvdpQX1YXV1oWGvXxQUtqw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v5 10/11] mm: lru: add VM_BUG_ON_FOLIO to lru maintenance function Message-ID: References: <20220530074919.46352-1-songmuchun@bytedance.com> <20220530074919.46352-11-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220530074919.46352-11-songmuchun@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655668172; a=rsa-sha256; cv=none; b=d9DdUpxUlChPHMCAbtsGT0oFepD57rzMUInUqQ4tbIyyhJhrJd2nvd/Rl32emp57INrdae rdFVvcFf611NbvRAuX7wUBRBfTliYraF3UtqEJYTNBcRCc1uWKyGkoSk4ctCLP4Jo3MQlb jq2plk92FtWBsoRV1h9ZwX2JjORKsTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655668172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XTYDF9D1xRBqvEkIY/ONzMnvR1i6T1Y9BCxsJP7NEik=; b=yuh2N8nbkKgRg6ofXI3m5IjbwhIeg8adqwtyZ8Mawog/TtifbJjfe+oM0M7DCbU0Y6Dz/f w6ksvEQTG2qGrIV0qeld//wQL3wZPWJuvGpqDQbCZVJuoHteWIqq725ZCLI8hkW0vHLIzj hG28JNklIeIkKuEkqEFm/ECi5yrwMC0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iL6YfmMA; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iL6YfmMA; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C780B18000F X-Stat-Signature: 6xkrjj836ynax1bgg6iudcx5d5jyj7jq X-HE-Tag: 1655668172-186828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 30, 2022 at 03:49:18PM +0800, Muchun Song wrote: > We need to make sure that the page is deleted from or added to the > correct lruvec list. So add a VM_WARN_ON_ONCE_FOLIO() to catch > invalid users. Then the VM_BUG_ON_PAGE() in move_pages_to_lru() > could be removed since add_page_to_lru_list() will check that. > > Signed-off-by: Muchun Song Acked-by: Roman Gushchin