From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8071EC433EF for ; Sun, 19 Jun 2022 12:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B16E6B0074; Sun, 19 Jun 2022 08:15:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1614A6B0075; Sun, 19 Jun 2022 08:15:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051BD6B0078; Sun, 19 Jun 2022 08:15:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E9C106B0074 for ; Sun, 19 Jun 2022 08:15:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BC67C34B20 for ; Sun, 19 Jun 2022 12:15:13 +0000 (UTC) X-FDA: 79594880106.27.613A782 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id CE05E4000E for ; Sun, 19 Jun 2022 12:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7llaUwzXeIV+bHJ3qcUCoCm8YsDXb15x+dYYJ/6k7no=; b=B3YWY8PBR+RWm0mKS/0ejoYOQp 3cW6UFzLyQ4RKidf988awHWl++QRDYJRAWzU51GXEmQKPktxhF62dfFlyBK13Gzqz1D+MSGO8/Gth biCWinHP5ZwN/IjUkvXgFcWsXU60H6FI8+atJBKfUD8XXwj4TadKDf5AEBjxfysV71k0Gvc7wm6Im 4lopWTU58b+B7RBgQpWyABgng6ivwViGNKnbqLbiR57yDfe0DoMVgOg7Pdbp/OFDa74ingkVUnk5+ y9f1bSbc8sT0dsUf0L5Eiej9DYj9XRiyy9oYUJjv9+fEqF0Fqnzlz+RKpdOWxOQENVfqCHOMfkqsa 0rcEL3hg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2tpa-004L4N-DB; Sun, 19 Jun 2022 12:15:06 +0000 Date: Sun, 19 Jun 2022 13:15:06 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Bob Peterson , Andreas Gruenbacher , cluster-devel@redhat.com, linux-mm@kvack.org Subject: Re: gfs2 is unhappy on pagecache/for-next Message-ID: References: <20220619070559.GA27401@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220619070559.GA27401@lst.de> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655640913; a=rsa-sha256; cv=none; b=qI2EX2Xgj26sHYzDxTUR/fhk4zbEouBiAb2Om3lAS8pz/TQAZhXIL0rXMG6Sh3UQIw+zVJ LAtuZlNLzLZa4BTKJb/mx3wYjYd2U8AI92o6JUaX/7phNJZEptNCjaSveJ0ZRAnqCobjY0 ajTFYFFTp5HhW89jckRjC1KT5zJ+YFw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=B3YWY8PB; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655640913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7llaUwzXeIV+bHJ3qcUCoCm8YsDXb15x+dYYJ/6k7no=; b=jQGU2VmYsXJodEte2cA07dwlairZ2ksKiA8r89ffoPyBRmw9B7boO7JsVOYCRsBHeiHdmk vrrrxqtS8cIgBHBK6G+e09SRROYCOm32ZCZtDa52suHt+5zUdXo0tnfcNr6iDeOOEaRfp7 6mMN/wuz0DExaAA1X4+lQTD+mxW/VfA= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=B3YWY8PB; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Stat-Signature: 47j1wrmgcqnqui3otyk75e31ki1ya3ga X-Rspamd-Queue-Id: CE05E4000E X-Rspamd-Server: rspam08 X-HE-Tag: 1655640912-919055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 19, 2022 at 09:05:59AM +0200, Christoph Hellwig wrote: > When trying to run xfstests on gfs2 (locally with the lock_nolock > cluster managed) the first mount already hits this warning in > inode_to_wb called from mark_buffer_dirty. This all seems standard > code from folio_account_dirtied, so not sure what is going there. I don't think this is new to pagecache/for-next. https://lore.kernel.org/linux-mm/cf8bc8dd-8e16-3590-a714-51203e6f4ba9@redhat.com/ > > [ 30.440408] ------------[ cut here ]------------ > [ 30.440409] WARNING: CPU: 1 PID: 931 at include/linux/backing-dev.h:261 __folio_mark_dirty+0x2f0/0x380 > [ 30.446424] Modules linked in: > [ 30.446828] CPU: 1 PID: 931 Comm: kworker/1:2 Not tainted 5.19.0-rc2+ #1702 > [ 30.447714] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014 > [ 30.448770] Workqueue: gfs_recovery gfs2_recover_func > [ 30.449441] RIP: 0010:__folio_mark_dirty+0x2f0/0x380 > [ 30.450113] Code: e8 b5 69 12 01 85 c0 0f 85 6a fe ff ff 48 8b 83 a8 01 00 00 be ff ff ff ff 48 8d 78 2 > [ 30.452490] RSP: 0018:ffffc90001b77bd0 EFLAGS: 00010046 > [ 30.453141] RAX: 0000000000000000 RBX: ffff8881004a3d00 RCX: 0000000000000001 > [ 30.454067] RDX: 0000000000000000 RSI: ffffffff82f592db RDI: ffffffff830380ae > [ 30.454970] RBP: ffffea000455f680 R08: 0000000000000001 R09: ffffffff84747570 > [ 30.455921] R10: 0000000000000017 R11: ffff88810260b1c0 R12: 0000000000000282 > [ 30.456910] R13: ffff88810dd92170 R14: 0000000000000001 R15: 0000000000000001 > [ 30.457871] FS: 0000000000000000(0000) GS:ffff88813bd00000(0000) knlGS:0000000000000000 > [ 30.458912] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 30.459608] CR2: 00007efc1d5adc80 CR3: 0000000116416000 CR4: 00000000000006e0 > [ 30.460564] Call Trace: > [ 30.460871] > [ 30.461130] mark_buffer_dirty+0x173/0x1d0 > [ 30.461687] update_statfs_inode+0x146/0x187 > [ 30.462276] gfs2_recover_func.cold+0x48f/0x864 > [ 30.462875] ? add_lock_to_list+0x8b/0xf0 > [ 30.463337] ? __lock_acquire+0xf7e/0x1e30 > [ 30.463812] ? lock_acquire+0xd4/0x300 > [ 30.464267] ? lock_acquire+0xe4/0x300 > [ 30.464715] ? gfs2_recover_func.cold+0x217/0x864 > [ 30.465334] process_one_work+0x239/0x550 > [ 30.465920] ? process_one_work+0x550/0x550 > [ 30.466485] worker_thread+0x4d/0x3a0 > [ 30.466966] ? process_one_work+0x550/0x550 > [ 30.467509] kthread+0xe2/0x110 > [ 30.467941] ? kthread_complete_and_exit+0x20/0x20 > [ 30.468558] ret_from_fork+0x22/0x30 > [ 30.469047] > [ 30.469346] irq event stamp: 36146 > [ 30.469796] hardirqs last enabled at (36145): [] folio_memcg_lock+0x8c/0x180 > [ 30.470919] hardirqs last disabled at (36146): [] _raw_spin_lock_irqsave+0x59/0x60 > [ 30.472024] softirqs last enabled at (33630): [] __irq_exit_rcu+0xd7/0x130 > [ 30.473051] softirqs last disabled at (33619): [] __irq_exit_rcu+0xd7/0x130 > [ 30.474107] ---[ end trace 0000000000000000 ]--- > [ 30.475367] ------------[ cut here ]------------ > >