From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5A8C433EF for ; Sat, 18 Jun 2022 10:34:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C91416B0071; Sat, 18 Jun 2022 06:34:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C40246B0072; Sat, 18 Jun 2022 06:34:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B07416B0073; Sat, 18 Jun 2022 06:34:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A20AE6B0071 for ; Sat, 18 Jun 2022 06:34:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 667DD20E8F for ; Sat, 18 Jun 2022 10:34:53 +0000 (UTC) X-FDA: 79590998466.20.61D6D4A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 32D77C00B2 for ; Sat, 18 Jun 2022 10:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XDQYopvY+n0JyKPmW0NgGxfaIg7ptxNKbg5tiL90yf4=; b=f52cnHOzcNZsJ0dPtfJpa6RtMC 6cP9oGvpz505NKdQXmMUHHLJ5qHC+ZAmqtqiD5S65X3Kzi3/mNGc/vFA25eufTyu5/lbr8/mnhuAG 8h3kNgjkFHZLHFKCfYqXcuErKGMyyWJHdusPX6hD2v+ByRt0wAjOK+wnTIseQ1AniycFdoVOt5KmH +0PcfgAQH5upv5nR+RmIKc9fTZR5QdFEjagK/l15tLu4Oo5mzHyt8253KvcK0M+c7Cun96AnmW/4S HKOQWIlNWJpyr05ItQjfOxN7CAeEAM6ekhpvt8qa977OjiJ+ab+1NsKEehjbHHfnfsGRT6Zw21LWx rFAKvIog==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2Vmr-003d2E-4c; Sat, 18 Jun 2022 10:34:41 +0000 Date: Sat, 18 Jun 2022 11:34:41 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] filemap: obey mapping->invalidate_lock lock/unlock order Message-ID: References: <20220618083820.35626-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220618083820.35626-1-linmiaohe@huawei.com> ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f52cnHOz; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655548493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XDQYopvY+n0JyKPmW0NgGxfaIg7ptxNKbg5tiL90yf4=; b=w68OheY5egTVxbcfMhABgWW359WymJzAjn5Zd1FaWrnDKdwAotPhmQ2y9tKd+o4ZoOOf3B SIv5hveYzHhsYx66Qz9StFT2Jn6KTG+uWMqrAy4gluLjz3eXz/k5NQuENEkxdGPHHPdAN7 wQ0ugw1OG5dh/hSa5dZD1iBO1TOb0nA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655548493; a=rsa-sha256; cv=none; b=vTmLOitdD7G3P34QzfrJT+TTS20uI7ukUx6DMeMAb40oMLznWFy6CPtP2hID3yR1EXaxHO DW7Q8egNlTFmeRSZJn2aD7PYSLKJ/JHCiOZq49KrQQxdqNKEy1vbohALnt/5Rpvsr/n7E6 Nr2yfH7p6Ec/9e7ZI+1lnYQ+BTIeq2M= X-Stat-Signature: uhdi9guidg5dao1yqc8zyjtcisk1kdpj X-Rspamd-Queue-Id: 32D77C00B2 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f52cnHOz; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam10 X-HE-Tag: 1655548492-631377 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 18, 2022 at 04:38:20PM +0800, Miaohe Lin wrote: > The invalidate_locks of two mappings should be unlocked in reverse order > relative to the locking order in filemap_invalidate_lock_two(). Modifying Why? It's perfectly valid to lock(A) lock(B) unlock(A) unlock(B). If it weren't we'd have lockdep check it and complain.