From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D30C43334 for ; Mon, 20 Jun 2022 04:54:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 302056B0073; Mon, 20 Jun 2022 00:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B1F46B0074; Mon, 20 Jun 2022 00:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19F968E0002; Mon, 20 Jun 2022 00:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 093E66B0073 for ; Mon, 20 Jun 2022 00:54:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D5856609DB for ; Mon, 20 Jun 2022 04:54:54 +0000 (UTC) X-FDA: 79597399308.27.1AD4564 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 8AE7FA000F for ; Mon, 20 Jun 2022 04:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j30w33pgKvnkmiJ8DHGQfIQa6b/GR+VvA+wwmWWYK7E=; b=O2Mz1eTEa1YyqV2pwYjciVC6Ar OPnfdVrsHZk+V0zKt7DQys+D5CF+U4oJ3lXxZIokHK6DTDVMCruAg9U4hdqtq6fb2kR7X7C7HhiIC qW6gEEie9tDL1Xqk9au/p6lSkP546hglKd8ESKyEN2cgk7qL8mrlUICPzWldciRfQqWxOctuxKNSH kndVFTo93k9kRQ1iLyD0s3ZNs9YLjeiJyN0SKGXvKSw6tjTydG6LqM6Z0mUu7S/Y1FZEUne+usQM7 thjX8lz0NebgrIrbyhE3+uHjR+KiTTTxOvDfKlV16di0qyb7OopMtQ5JVRah8sfxstCNWXNh5HLJG PkAQ6DbQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o39R2-004sEZ-P9; Mon, 20 Jun 2022 04:54:48 +0000 Date: Mon, 20 Jun 2022 05:54:48 +0100 From: Matthew Wilcox To: David Laight Cc: 'Kent Overstreet' , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "pmladek@suse.com" , "rostedt@goodmis.org" , "enozhatsky@chromium.org" , "linux@rasmusvillemoes.dk" Subject: Re: [PATCH v4 00/34] Printbufs - new data structure for building strings Message-ID: References: <20220620004233.3805-1-kent.overstreet@gmail.com> <0a5901f8460f452a89c9b0cda32fb833@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a5901f8460f452a89c9b0cda32fb833@AcuMS.aculab.com> ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O2Mz1eTE; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655700894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j30w33pgKvnkmiJ8DHGQfIQa6b/GR+VvA+wwmWWYK7E=; b=7wGCp0c+VLOCNBEBNeSeUFYYvTlqswQfXkPRicy3qkErygWig4ltJlCCyqTPZiomSSQogU abtzLbQe13nVsmB1TyZsZqlyFGGL9vhatvq7Cy7QjMpf7SlgZMVrGqfNX5WGLl2xn0iNP/ kYKKntNbn0nGwgS3ZN4VqGUfc9sTWMM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655700894; a=rsa-sha256; cv=none; b=5R3Kqc02lYkENPoUjaWIjZ7iJP7kimyjk72fjvm1aIXFNY4WIGBv1ZIzehWQAvmo0VWFGt hq9ZfS4eLxfkO4ugfBH5wM1SJ3WMHou3H+riHkWZblHewQu+gh7fQlmN7ax1KETIfiAJqL mZs7SVXGHmsZXRaYdsToXPFOiqLFtEk= X-Rspamd-Queue-Id: 8AE7FA000F Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O2Mz1eTE; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: u6rwacoifcfhayjfcnpn1pnjjrrccaae X-HE-Tag: 1655700894-232991 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 20, 2022 at 04:19:31AM +0000, David Laight wrote: > I really think that is a bad idea. > printk() already uses a lot of stack, anything doing a recursive > call is just making that worse. > Especially since these calls can often be in error paths > which are not often tested and can already be on deep stacks. You made this complaint last time and I challenged you to provide data. You have not, as yet, provided data.