From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221E9C433EF for ; Sat, 4 Jun 2022 09:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34E396B0071; Sat, 4 Jun 2022 05:42:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F9FE6B0073; Sat, 4 Jun 2022 05:42:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 198B46B0074; Sat, 4 Jun 2022 05:42:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 061326B0071 for ; Sat, 4 Jun 2022 05:42:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ACE2C21326 for ; Sat, 4 Jun 2022 09:42:57 +0000 (UTC) X-FDA: 79540064394.13.B9CFDC6 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf15.hostedemail.com (Postfix) with ESMTP id 8D222A0034 for ; Sat, 4 Jun 2022 09:42:32 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id a10so7834749ioe.9 for ; Sat, 04 Jun 2022 02:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=unzjzvfi9PrBQZfrjQ2iDmRQxsZtvSAfZhjP5fuk9Mc=; b=PPQ2PINKv89eSRuXsNMTWrGuBW1KBti3kaS9DjJDXmELyPqkm6tD+GfOKje7/L9uO4 vlARQyB44pTmG8AA2dKoceJLx3GM62KEjS/tKBc0lw8lOtSxIAUoZOLHQv9FpGs3Uz01 GQ6K5LJyhxTHEJYlXVGCQx9q+wmp2p2AIYYVL2JX90ln57WV/1m43dTXMZ0If9z8NEyp vq41oPTzt8Y2q8PXwHtM2yaz+gQ7eKDXoR2pkyk2IwQrLO5KgnO0yH7rb1VZE84y3Lnn 6dtW5YvDt/BE1s+HRVyRE7cADebazJAJt1t8VmaonH0cIDXN0PKIkOAMOnt+gth0tMCz Nwaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=unzjzvfi9PrBQZfrjQ2iDmRQxsZtvSAfZhjP5fuk9Mc=; b=tDmfRv40MVP+mi2Kw6TmGJV85LShI+3jArT4TtWIIICeGspe/MGxNJjycoLkUS0NN3 8AE21Tcj+sJzvfUm74EzP+urE3l9SSMe6mJQJYubUhhSGTUdMk4IbRtuh9zT6+LpNr9Q Fym2lfTjeHil268/OE8W22NYEAdv+FktZ0hnDuT6bKgtld6+4mS2dSX/v2KLEX2MED/p UkIjgqjuL4QZoQBnRurrsY0dzBJ7LPdrQA9y70Sa+bQ6I8fF+n+kiKPYP728hbe6C+G2 MRTiAWd9Fh0S/geYDsmju4Feu4pcUT5bg9znCQq43mEzOvvAfMhF7SIVRwL3eba4C0bO /ctg== X-Gm-Message-State: AOAM531bfo9EbK31Px4NQSlulNxbMe75sn11Vc5pGS64NZ335NQ9a301 yrHduaSx6MITB6IbcGOfIgw= X-Google-Smtp-Source: ABdhPJzUE4jXudX1ZhVhdU5GnFLPG9UR6NhWdSPqYNJ8qtwUtJKYyfN8HzWXRflxi//NrvJTryIALA== X-Received: by 2002:a05:6602:1585:b0:665:5f6a:9d7a with SMTP id e5-20020a056602158500b006655f6a9d7amr6639010iow.154.1654335776607; Sat, 04 Jun 2022 02:42:56 -0700 (PDT) Received: from n2.us-central1-a.c.spheric-algebra-350919.internal (151.16.70.34.bc.googleusercontent.com. [34.70.16.151]) by smtp.gmail.com with ESMTPSA id r8-20020a02aa08000000b003314d1acddesm3498760jam.152.2022.06.04.02.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jun 2022 02:42:55 -0700 (PDT) Date: Sat, 4 Jun 2022 09:42:54 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: sxwjean@me.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: Re: [PATCH v2] mm/slub: Simplify __kmem_cache_alias() Message-ID: References: <20220603143555.41914-1-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603143555.41914-1-sxwjean@me.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8D222A0034 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PPQ2PINK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Stat-Signature: rn19nk9a4zmokaoqt9xpnwgg8hpdbagy X-Rspam-User: X-HE-Tag: 1654335752-738526 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 03, 2022 at 10:35:55PM +0800, sxwjean@me.com wrote: > From: Xiongwei Song > > There is no need to do anything if sysfs_slab_alias() return nonzero > value after getting a mergeable cache. > > Signed-off-by: Xiongwei Song > Reviewed-by: Muchun Song > --- > v2: Collect Reviewed-by tag from Muchun. > --- > mm/slub.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index d8d5abf49f5f..9444277d669a 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4861,6 +4861,9 @@ __kmem_cache_alias(const char *name, unsigned int size, unsigned int align, > > s = find_mergeable(size, align, flags, name, ctor); > if (s) { > + if (sysfs_slab_alias(s, name)) > + return NULL; > + > s->refcount++; > I think we should not expose sysfs attributes before initializing what can be read via sysfs attribute (object_size). > /* > @@ -4869,11 +4872,6 @@ __kmem_cache_alias(const char *name, unsigned int size, unsigned int align, > */ > s->object_size = max(s->object_size, size); this calculation should be done before sysfs_slab_alias(). Thanks, Hyeonggon > s->inuse = max(s->inuse, ALIGN(size, sizeof(void *))); > - > - if (sysfs_slab_alias(s, name)) { > - s->refcount--; > - s = NULL; > - } > } > > return s; > -- > 2.30.2 >