From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93B9C43334 for ; Fri, 3 Jun 2022 11:01:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1785F8D0002; Fri, 3 Jun 2022 07:01:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 124BE8D0001; Fri, 3 Jun 2022 07:01:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2CBF8D0002; Fri, 3 Jun 2022 07:01:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E560B8D0001 for ; Fri, 3 Jun 2022 07:01:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id A6F00120FAA for ; Fri, 3 Jun 2022 11:01:44 +0000 (UTC) X-FDA: 79536634128.24.5DE9955 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 4D81E120065 for ; Fri, 3 Jun 2022 11:01:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E22BBCE2364; Fri, 3 Jun 2022 11:01:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE193C385A9; Fri, 3 Jun 2022 11:01:37 +0000 (UTC) Date: Fri, 3 Jun 2022 12:01:34 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v2 0/4] mm: kmemleak: store objects allocated with physical address separately and check when scan Message-ID: References: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4D81E120065 Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Stat-Signature: 7nao6g3y8iamk77t3nip76okq5gicxa1 X-Rspam-User: X-HE-Tag: 1654254090-192548 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 03, 2022 at 11:54:11AM +0800, Patrick Wang wrote: > Patrick Wang (4): > mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical > address > mm: kmemleak: add rbtree for objects allocated with physical address > mm: kmemleak: handle address stored in object based on its type > mm: kmemleak: kmemleak_*_phys() set address type and check PA when > scan This looks fine at a very quick look but I'll do a in-depth review next week. One more thing needed is to remove the min_count argument to kmemleak_alloc_phys() and assume it's always 0. After this series we can't track them for leaking anyway. Thanks for putting this together. -- Catalin