From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C10C433EF for ; Thu, 2 Jun 2022 21:00:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30C546B0071; Thu, 2 Jun 2022 17:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B9036B0073; Thu, 2 Jun 2022 17:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 182796B0074; Thu, 2 Jun 2022 17:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 051146B0071 for ; Thu, 2 Jun 2022 17:00:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BD32021685 for ; Thu, 2 Jun 2022 21:00:10 +0000 (UTC) X-FDA: 79534513380.07.8F989DB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id E63EF180063 for ; Thu, 2 Jun 2022 21:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZMC0JMDJpU3Ea9On6JN2DLeBQ12wi64TMeGJm440bio=; b=LAGghuKhpFoBNIGZFIztX+f9Ct foa5z/E10Sydt2cFotdonoOIEyichjxplkMFoJR4Zh0cVptSTtlnkVnzwpLUvKqyl80ZgMDuNkk8T AHjt6nFNx+MGQi6tfrecRdCs9rjQvqh86Wynas+Dzig2h6MGksLjv8pe6nkDHz42r6tXjI65AMSLw /4O0CMEfCWrhKWGX9MuGpwkjhJiTeus/MBwBIMKobPjnvF0chObg9W/kgsW8OGrFr16e4WzO/o6m/ tEwJ0LpQIhHr27Uwss4XxPY0famMei6ZHdDivwiBOlTy3RbVRy4PM3lJftVICipyoPgax2Kn6ce+D Vjxrn2kg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwrvG-007QUZ-FK; Thu, 02 Jun 2022 21:00:02 +0000 Date: Thu, 2 Jun 2022 22:00:02 +0100 From: Matthew Wilcox To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH 5/7] mm: thp: kill transparent_hugepage_active() Message-ID: References: <20220602182159.248387-1-shy828301@gmail.com> <20220602182159.248387-6-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220602182159.248387-6-shy828301@gmail.com> Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LAGghuKh; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E63EF180063 X-Rspam-User: X-Stat-Signature: ww3zfx69bqt5fs6cddc645ibuwbhgney X-HE-Tag: 1654203605-292730 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 02, 2022 at 11:21:57AM -0700, Yang Shi wrote: > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 79d5919beb83..f315c70d5256 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -209,7 +209,9 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma) > !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode); > } > > -bool transparent_hugepage_active(struct vm_area_struct *vma); > +extern bool hugepage_vma_check(struct vm_area_struct *vma, Please remove the 'extern's. They add no value to function declarations.