From: Roman Gushchin <roman.gushchin@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org,
Kent Overstreet <kent.overstreet@gmail.com>,
Hillf Danton <hdanton@sina.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v5 6/6] mm: shrinkers: add scan interface for shrinker debugfs
Date: Thu, 2 Jun 2022 15:25:14 -0700 [thread overview]
Message-ID: <Ypk4yuvJQ1ObIEJH@carbon> (raw)
In-Reply-To: <20220602114132.f6e5675b2d2a4085b9b1e8c4@linux-foundation.org>
On Thu, Jun 02, 2022 at 11:41:32AM -0700, Andrew Morton wrote:
> On Wed, 1 Jun 2022 17:56:22 -0700 Roman Gushchin <roman.gushchin@linux.dev> wrote:
>
> > >
> > > > + ssize_t ret;
> > > > +
> > > > + if (copy_from_user(kbuf, buf, read_len))
> > > > + return -EFAULT;
> > > > + kbuf[read_len] = '\0';
> > > > +
> > > > + if (sscanf(kbuf, "%lu %d %lu", &ino, &nid, &nr_to_scan) < 2)
> > >
> > > Was it intentional to permit more than three args?
> >
> > Good catch! No, of course it wasn't intentional.
> >
> > Below is an updated version of this patch.
> >
> > ...
> >
> > + if (sscanf(kbuf, "%lu %d %lu", &ino, &nid, &nr_to_scan) != 2)
> > + return -EINVAL;
>
> s/2/3/methinks?
>
>
My bad, of course. Thanks!
--
diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c
index 12026472daae..e5b40c43221d 100644
--- a/mm/shrinker_debug.c
+++ b/mm/shrinker_debug.c
@@ -124,7 +124,7 @@ static ssize_t shrinker_debugfs_scan_write(struct file *file,
return -EFAULT;
kbuf[read_len] = '\0';
- if (sscanf(kbuf, "%lu %d %lu", &ino, &nid, &nr_to_scan) != 2)
+ if (sscanf(kbuf, "%lu %d %lu", &ino, &nid, &nr_to_scan) != 3)
return -EINVAL;
if (nid < 0 || nid >= nr_node_ids)
next prev parent reply other threads:[~2022-06-02 22:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 3:22 [PATCH v5 0/6] mm: introduce shrinker debugfs interface Roman Gushchin
2022-06-01 3:22 ` [PATCH v5 1/6] mm: memcontrol: introduce mem_cgroup_ino() and mem_cgroup_get_from_ino() Roman Gushchin
2022-06-01 3:22 ` [PATCH v5 2/6] mm: shrinkers: introduce debugfs interface for memory shrinkers Roman Gushchin
2022-06-01 21:23 ` Andrew Morton
2022-06-02 0:31 ` Roman Gushchin
2022-06-01 3:22 ` [PATCH v5 3/6] mm: shrinkers: provide shrinkers with names Roman Gushchin
2022-06-01 3:22 ` [PATCH v5 4/6] mm: docs: document shrinker debugfs Roman Gushchin
2022-06-01 3:22 ` [PATCH v5 5/6] tools: add memcg_shrinker.py Roman Gushchin
2022-06-01 3:22 ` [PATCH v5 6/6] mm: shrinkers: add scan interface for shrinker debugfs Roman Gushchin
2022-06-01 21:23 ` Andrew Morton
2022-06-02 0:56 ` Roman Gushchin
2022-06-02 18:41 ` Andrew Morton
2022-06-02 22:25 ` Roman Gushchin [this message]
2022-06-17 2:26 ` [PATCH v5 0/6] mm: introduce shrinker debugfs interface Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ypk4yuvJQ1ObIEJH@carbon \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dchinner@redhat.com \
--cc=hdanton@sina.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox