From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DB7C43334 for ; Thu, 2 Jun 2022 03:06:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1524B6B0071; Wed, 1 Jun 2022 23:06:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 101616B0072; Wed, 1 Jun 2022 23:06:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE1A16B0073; Wed, 1 Jun 2022 23:06:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC5E76B0071 for ; Wed, 1 Jun 2022 23:06:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9826135614 for ; Thu, 2 Jun 2022 03:06:44 +0000 (UTC) X-FDA: 79531808328.05.2572BC7 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf12.hostedemail.com (Postfix) with ESMTP id 65EC340099 for ; Thu, 2 Jun 2022 03:06:00 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id s68so3593079pgs.10 for ; Wed, 01 Jun 2022 20:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2wNLI+UiPxMD8gpYb8X0rEwvSxrz6cSA2s7fFzdJJpo=; b=U7mxsOuX6jlRQc/N2wDNPLldG8N8Q//HPEH8MZkAnJQTYBblNNDA6fvJcYZa2+ajhu r7v8owfFW4WH9wCmj4KA9V7eXigowV+GwmRcRsY/bmS96PzTs2Y4LN+gvpOvNDeyWh6g GXxB6XFIimI5GljV7sKZpmyYYoAHvuFXHsvc5wRHpAnt/h4J44rLOBoDqGvTKwjXY9lN lA8WlNUJq4AZRgtThcD+jnB/opVPFJ1f7MmsBfaOgQu1AJyDo5hFyWPpGqzd6wvSo2PF 14kSrZTDwtXro5yUWNjjwaUt5ut8ETmbwzfNA0W6I4LXQ0KDtbjiiWhgeGQqHGOw8UOM KM4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2wNLI+UiPxMD8gpYb8X0rEwvSxrz6cSA2s7fFzdJJpo=; b=nypVmrtr60vDEKAgNriEC1lMKXYfgL/0bmTqkv4NjvzfkIctGnjN0GzXBd4qLYqdXv HSuLU8rk8jwPZ+SkEqH34ydmNDx+YLsFL6vc6shYiSh64i0Ue+aLoomp+H8lJl4OeWfD z5w8AFU8qgf8sjnLiBaWLnPZcbAhkzjSfa2jj8T9UUfvCtohOYsJeV/fyOdcYT6bMk7D fMApFhevaenP6mC8C3OZ0TUg5ZoaWsB5xnkRT6B8RfVziD1JpZc6eArrHeYBn1oXKwBx ppX/tjS4sVIhn1ECqdsSqzZYkyj3lWLZHuLqTthxSUDcwIneDWZ8PAVv5LR3p7eL46Gg oadg== X-Gm-Message-State: AOAM531l0xB5tUg37V2AHfh3hzIw4MPAyes+oKG11mxSGhq7cq+RBB2+ 23gC2bc3kParJB7CQkaw81poUA== X-Google-Smtp-Source: ABdhPJyCOcJbpRbXJqeVRd/304cyIed9Z6+PjPA9f74qJZ36s3xgnk3oFV7hWHEbHUgOVebZGcEixg== X-Received: by 2002:a63:db47:0:b0:3fc:17e5:9fbb with SMTP id x7-20020a63db47000000b003fc17e59fbbmr2215874pgi.504.1654139201494; Wed, 01 Jun 2022 20:06:41 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:2468:2a68:7bbe:680c]) by smtp.gmail.com with ESMTPSA id s16-20020aa78bd0000000b0051bbd79fc9csm960267pfd.57.2022.06.01.20.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 20:06:41 -0700 (PDT) Date: Thu, 2 Jun 2022 11:06:35 +0800 From: Muchun Song To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v5 03/11] mm: memcontrol: prepare objcg API for non-kmem usage Message-ID: References: <20220530074919.46352-1-songmuchun@bytedance.com> <20220530074919.46352-4-songmuchun@bytedance.com> <20220601173434.GB16134@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220601173434.GB16134@blackbody.suse.cz> Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=U7mxsOuX; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 65EC340099 X-Rspam-User: X-Stat-Signature: brs7xwqqb895t9n3ks9tnzfptcrtcuh1 X-HE-Tag: 1654139160-410745 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 01, 2022 at 07:34:34PM +0200, Michal Koutný wrote: > Hello. > > On Mon, May 30, 2022 at 03:49:11PM +0800, Muchun Song wrote: > > So we also allocate an object cgroup for the root_mem_cgroup. > > This change made me wary that this patch also kmem charging in the > root_mem_cgroup. Fortunately, get_obj_cgroup_from_current won't return Sorry for the confusing. Right, we don't charge kmem to the root objcg. > this objcg so all is fine. > > > +} > > +#else > > +static inline void obj_cgroup_release_bytes(struct obj_cgroup *objcg) > > +{ > > +} > > +#endif > > This empty body is for !CONFIG_MEMCG_KMEM, however, the subsequent use for LRU > pages makes no use of these, so it's warranted. > > Altogether, I find this correct, hence > Reviewed-by: Michal Koutný > Thanks Michal.