From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EC8C43334 for ; Thu, 2 Jun 2022 00:31:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FB236B0071; Wed, 1 Jun 2022 20:31:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6476B0072; Wed, 1 Jun 2022 20:31:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26F406B0073; Wed, 1 Jun 2022 20:31:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 18F0D6B0071 for ; Wed, 1 Jun 2022 20:31:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D81B9214ED for ; Thu, 2 Jun 2022 00:31:11 +0000 (UTC) X-FDA: 79531416342.27.7D816C1 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf07.hostedemail.com (Postfix) with ESMTP id 59F4C4005B for ; Thu, 2 Jun 2022 00:30:58 +0000 (UTC) Date: Wed, 1 Jun 2022 17:31:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1654129868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qp+wb8ntoYKonlACt1dWRVIscCiQhmJA/jSAIppfpWc=; b=PwmGWr5SGjizofp8OH+1vXp8YX4tsSjWP8krwRrDurlPT8Vbt0j5uKOPcDwu/2R1K9RlmC gHlfdKfRV7NHBaAiFuOEmCEb1cTxxdjYViR1ybbTAgu3DCbAnt7jPzMzkI0XRrpwLAzq/+ AhdrHDH87NE+qwokhsRgAmqaTbzsyuM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Andrew Morton Cc: linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Kent Overstreet , Hillf Danton , Christophe JAILLET , Muchun Song Subject: Re: [PATCH v5 2/6] mm: shrinkers: introduce debugfs interface for memory shrinkers Message-ID: References: <20220601032227.4076670-1-roman.gushchin@linux.dev> <20220601032227.4076670-3-roman.gushchin@linux.dev> <20220601142358.75a6c9c5d4a988bd58667717@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220601142358.75a6c9c5d4a988bd58667717@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspamd-Queue-Id: 59F4C4005B X-Stat-Signature: zs9rdndn16rc7g149mqu4o37py9osbgo X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PwmGWr5S; spf=pass (imf07.hostedemail.com: domain of roman.gushchin@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspamd-Server: rspam08 X-HE-Tag: 1654129858-553770 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 01, 2022 at 02:23:58PM -0700, Andrew Morton wrote: > On Tue, 31 May 2022 20:22:23 -0700 Roman Gushchin wrote: > > > This commit introduces the /sys/kernel/debug/shrinker debugfs > > interface > > Should it be at the top level? Maybe /sys/kernel/debug/vm/shrinker > would be more future-safe. (or .../mm/...) There are already some top-level mm-related items (slab, zswap, extfrag, etc) and I don't think there will be non-mm shrinkers in the kernel (given that it's a kernel-wide API). But no strong opinion here, if you strongly prefer mm/ or vm/, I'm happy to change it. Thanks!