From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91ACC433F5 for ; Wed, 1 Jun 2022 11:56:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A9018D000B; Wed, 1 Jun 2022 07:56:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 155558D0006; Wed, 1 Jun 2022 07:56:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F383F8D000B; Wed, 1 Jun 2022 07:56:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E0A9A8D0006 for ; Wed, 1 Jun 2022 07:56:39 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id B5A4F80763 for ; Wed, 1 Jun 2022 11:56:39 +0000 (UTC) X-FDA: 79529514918.06.DE63296 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf23.hostedemail.com (Postfix) with ESMTP id 0A67514006A for ; Wed, 1 Jun 2022 11:56:12 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id e66so1684022pgc.8 for ; Wed, 01 Jun 2022 04:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pR6VzLoG/n8Hl9GbCmfWr6M9WLjiGWY3XL3BO0710dM=; b=w6WHPfiAa2BV+6s2Aq+bTPDlC3usBQQMUEzBNO9v68Ym/XmdcCTaiut0SFHNA5JtEs PeDc1Jch6hPTLaX+2tZxz9rxEFnVL3qAYPGJWp9krdPas0eTy+o+2BUe5cJaAAY24dU4 3tSkFPc+dG9/uLbT+Of1zSZ+S/AQv6OP/H+1pKxQ7sJmXR80+gwIe1rabajINc9aRrly 3eSpIw8dDhQvYURe8U06jgFjHGg1lC8nF8/RapYfjKXYKZkZH9kcLTVlP37U4L+qIw86 D+pxNhJxwpgJlN9aNw/ZhFWcJwtMJSsz+B9I0kM0OfR4ywm9IYjUAb9Wrldo9qxs5qFh 8SQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pR6VzLoG/n8Hl9GbCmfWr6M9WLjiGWY3XL3BO0710dM=; b=p62fM/8p9KkjLEqFx3AV/TTgn2N4ddMCFUXdo+Wt9dBfyLvICQJbHIX6INT1Iu1cVg gYoSXT27qN8ybMDHmcIiYsduU8LIjWdLROPiqeBd8DoeBEDXCVlABFMdnd/3cPSTHOGy zo18+P5dnGc1UqGG+VN926GcDjGg6RtO2ZaEjQeR1pt8pWCnfeW1TNbtg96+A9/feqiQ u1voXg098rVn2woXij/zifCOZz2J71h+AJooMwNXeWdjNF82qOyhd5nGdln29Fyelwv4 /AKM9hANa9Qw/eVANg64ujkB45lD7rs/91Cr1lcbnw/cSTZ/MV3cr8wnBqU+nGpEKmIm wWwA== X-Gm-Message-State: AOAM532EhSaBLDhM38vzpJkEMhKzBGEWiR+ySKVAqQrBAFS+CP04PVSA 7lZn7W7FwFfAikc1/QTGIAFGvQ== X-Google-Smtp-Source: ABdhPJwSk3VUFjJDwUrgUxbBIoYw9ZfLI5bPXe34CUD6GqwF15lJ0NA1xUR3OJNC13SbIdMmemLHEQ== X-Received: by 2002:a05:6a00:994:b0:518:6f30:502d with SMTP id u20-20020a056a00099400b005186f30502dmr59379307pfg.68.1654084597086; Wed, 01 Jun 2022 04:56:37 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:f9bc:fb5f:5b66:a80e]) by smtp.gmail.com with ESMTPSA id g29-20020aa79ddd000000b0050dc762819esm1264305pfq.120.2022.06.01.04.56.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 04:56:36 -0700 (PDT) Date: Wed, 1 Jun 2022 19:56:31 +0800 From: Muchun Song To: David Hildenbrand Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP* Message-ID: References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=w6WHPfiA; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf23.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0A67514006A X-Rspam-User: X-Stat-Signature: gjc895qe16d5ejgpudbr68gwmi1im9kk X-HE-Tag: 1654084572-469682 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 01, 2022 at 12:10:29PM +0200, David Hildenbrand wrote: > On 01.06.22 11:54, Muchun Song wrote: > > On Wed, Jun 01, 2022 at 11:32:37AM +0200, David Hildenbrand wrote: > >> On 04.04.22 09:46, Muchun Song wrote: > >>> The word of "free" is not expressive enough to express the feature of optimizing > >>> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze". > >>> In this patch , cheanup configs to make code more expressive. > >> > >> Nit: why not simply CONFIG_HUGETLB_OPTIMIZE_VMEMMAP if we're touching > >> this already? At least I don't see value in the additional "PAGE" :) > >> > > > > I thought it keep consistent with CONFIG_HUGETLB_PAGE. If you think > > CONFIG_HUGETLB_OPTIMIZE_VMEMMAP is a better name, maybe we need to > > another separate patch since this series is already on mm-stable branch. > > I see, makes sense then. > > >>> > >>> Signed-off-by: Muchun Song > >>> --- > >>> Documentation/admin-guide/kernel-parameters.txt | 4 ++-- > >>> Documentation/admin-guide/mm/hugetlbpage.rst | 2 +- > >>> arch/arm64/Kconfig | 2 +- > >>> arch/arm64/mm/flush.c | 2 +- > >>> arch/x86/Kconfig | 2 +- > >>> arch/x86/mm/init_64.c | 2 +- > >>> fs/Kconfig | 16 ++++++++-------- > >>> include/linux/hugetlb.h | 2 +- > >>> include/linux/mm.h | 2 +- > >>> include/linux/page-flags.h | 6 +++--- > >>> mm/Makefile | 2 +- > >>> mm/hugetlb_vmemmap.c | 4 ++-- > >>> mm/hugetlb_vmemmap.h | 4 ++-- > >>> mm/sparse-vmemmap.c | 4 ++-- > >>> 14 files changed, 27 insertions(+), 27 deletions(-) > >>> > >>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > >>> index 56edbe3f458f..89a58ac49d5f 100644 > >>> --- a/Documentation/admin-guide/kernel-parameters.txt > >>> +++ b/Documentation/admin-guide/kernel-parameters.txt > >>> @@ -1660,7 +1660,7 @@ > >>> Format: size[KMG] > >>> > >>> hugetlb_free_vmemmap= > >> > >> We didn't change the parameter name in #2, correct? > >> > > > > I think this is a interface to users. Is it correct to > > change it? > > I guess so ... I was just wanted to confirm that this is still correct :) > Well, I think it is not correct to change it since it could change behavior to users. :-) Thanks.