From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932ECC433EF for ; Wed, 1 Jun 2022 09:54:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 295DE6B007E; Wed, 1 Jun 2022 05:54:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 246046B0089; Wed, 1 Jun 2022 05:54:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 156B46B0093; Wed, 1 Jun 2022 05:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 05AEB6B007E for ; Wed, 1 Jun 2022 05:54:11 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 88BA312078D for ; Wed, 1 Jun 2022 09:54:10 +0000 (UTC) X-FDA: 79529206260.12.729E544 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf27.hostedemail.com (Postfix) with ESMTP id 3C87F4004D for ; Wed, 1 Jun 2022 09:54:05 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id n10so1526856pjh.5 for ; Wed, 01 Jun 2022 02:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e0X3nukNsLOhh6Y9CwwnQna0l5z5ykZ7aUl5rmtL/+E=; b=majHexgf9bZrG6j89RxBARjC4r4/myBR0n4vbdDVCWqmrs1Rw5jzT206JsmizuE8BM 7DnboMS+fAMQVqPVmMp4ZIaw7AEVbsMJp/qJvq21xpPxHynppuiy/wFtI/nibejLBJzY fajfgkkCUVDeNWBsvCqFxY9NEaS7oPX/urrCvQRQton/nzrHwol37OhfOLaVcYgrRHWf oJDo2a/WPIO1zh6tT+subXTxm2Gz6YS+LnNRdo4926Aw5p4hUXJpQIwv+a7oFxErT/9m nSB+YiX7cQXupp9czW22mI90l2Fe3VTm6U+C8BxEtYWe5BqvTmkOBKPuabO1QVjUv0qH cYtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e0X3nukNsLOhh6Y9CwwnQna0l5z5ykZ7aUl5rmtL/+E=; b=ySB0ajp7Jx88bjgz/gIGFxj989m1tz8DfmKFkCyvZxWjTsetUxZpojoHEPawU/4xNU WJDHpuALMyP1ilsin4LkJTqVbFRlPUJPlufmtluG8gcktvnSpzyNM5QT35sxzCdQ1gyt onQqTyzyU4MrkJSsPdtIW0XRhUQcI+b/E61r4yJcQNa8xjl6+VWzh4eM74ioqgo++r+9 dfda8J18TzCV4t0gDDBaIHUxsNUvjP9fgaPQ/O04FXTi3+G5mS7eqBHE8U3JeCZGFWDF S3VndNYCp0qtiExQ9NElz5SZ+Z85M34AOX4/fY/r5+jZ2Hz4XgdYgoB1NFkIPWeKbQsv UnmQ== X-Gm-Message-State: AOAM532AAWnkwYd76ImNdsmxdo+bImir9ymWQQqfFHLlZBnocjet8t9y 88YBj/xvJX1vP/nOTlk7MkfA+A== X-Google-Smtp-Source: ABdhPJw0Vdas5Ez2S0AVtmbs6S8PBW7lkn3x/2HBDyhbbY3eSGdom+a26dU8rcZUKgzNom8aPOsbwg== X-Received: by 2002:a17:902:e5ca:b0:164:1958:c84a with SMTP id u10-20020a170902e5ca00b001641958c84amr4779962plf.72.1654077247993; Wed, 01 Jun 2022 02:54:07 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:f9bc:fb5f:5b66:a80e]) by smtp.gmail.com with ESMTPSA id p16-20020a1709027ed000b0016403cae7desm364272plb.276.2022.06.01.02.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 02:54:07 -0700 (PDT) Date: Wed, 1 Jun 2022 17:54:02 +0800 From: Muchun Song To: David Hildenbrand Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP* Message-ID: References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3C87F4004D X-Stat-Signature: mcty8maaomhxtygph9ntysrwtgb1xa5w Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=majHexgf; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1654077245-902617 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 01, 2022 at 11:32:37AM +0200, David Hildenbrand wrote: > On 04.04.22 09:46, Muchun Song wrote: > > The word of "free" is not expressive enough to express the feature of optimizing > > vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze". > > In this patch , cheanup configs to make code more expressive. > > Nit: why not simply CONFIG_HUGETLB_OPTIMIZE_VMEMMAP if we're touching > this already? At least I don't see value in the additional "PAGE" :) > I thought it keep consistent with CONFIG_HUGETLB_PAGE. If you think CONFIG_HUGETLB_OPTIMIZE_VMEMMAP is a better name, maybe we need to another separate patch since this series is already on mm-stable branch. > > > > Signed-off-by: Muchun Song > > --- > > Documentation/admin-guide/kernel-parameters.txt | 4 ++-- > > Documentation/admin-guide/mm/hugetlbpage.rst | 2 +- > > arch/arm64/Kconfig | 2 +- > > arch/arm64/mm/flush.c | 2 +- > > arch/x86/Kconfig | 2 +- > > arch/x86/mm/init_64.c | 2 +- > > fs/Kconfig | 16 ++++++++-------- > > include/linux/hugetlb.h | 2 +- > > include/linux/mm.h | 2 +- > > include/linux/page-flags.h | 6 +++--- > > mm/Makefile | 2 +- > > mm/hugetlb_vmemmap.c | 4 ++-- > > mm/hugetlb_vmemmap.h | 4 ++-- > > mm/sparse-vmemmap.c | 4 ++-- > > 14 files changed, 27 insertions(+), 27 deletions(-) > > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > index 56edbe3f458f..89a58ac49d5f 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -1660,7 +1660,7 @@ > > Format: size[KMG] > > > > hugetlb_free_vmemmap= > > We didn't change the parameter name in #2, correct? > I think this is a interface to users. Is it correct to change it? Thanks.