From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE9E1C433F5 for ; Tue, 31 May 2022 21:40:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43F3F6B0071; Tue, 31 May 2022 17:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED986B0073; Tue, 31 May 2022 17:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 301946B0074; Tue, 31 May 2022 17:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 223A76B0071 for ; Tue, 31 May 2022 17:40:36 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id DAF0C60662 for ; Tue, 31 May 2022 21:40:35 +0000 (UTC) X-FDA: 79527357630.05.7305B7B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 51A4C160055 for ; Tue, 31 May 2022 21:40:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7DB346136E; Tue, 31 May 2022 21:40:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41D5AC385A9; Tue, 31 May 2022 21:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654033233; bh=LP+1R1cUBOgcGWazwUCC1e4KihA9N205ZsMLBqH7mAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JjPa68gOoTmBdt/Vqkgq304UPUbu/1zZFfLqGIJZqjxOTtpqN24LwMYPfBgEd8bHz rBlDFyt7h/BQSzR/h/vco5tmQU0IwXb9loR9AfYtb0AgMc/EsBTlKaMIirwYZ9ykaV mpHHZbLl0H6MjWdgm7AXfhL6h3Fy2QqKeZsjpgLGB32lviiy/d4TQmTZhgIUULQshM mSX9/VXZ30oXT0SM5edj6kvkioERX0KugjNIaD3LOcAMKojdXOn2gOFkpfLAr7kV8Z TzD1WFIPQPNhqjcKh4RfFMJXV0T/+MCKUhr61OyCFiNPW6hsR63jiigLMLdhXbh9ad 9GDhCaFQ6Amug== Date: Tue, 31 May 2022 15:40:30 -0600 From: Keith Busch To: Tony Battersby Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, kernel-team@fb.com, Matthew Wilcox , Andy Shevchenko , Robin Murphy , Tony Lindgren Subject: Re: [PATCH 08/10] dmapool: cleanup dma_pool_destroy Message-ID: References: <9b08ab7c-b80b-527d-9adf-7716b0868fbc@cybernetics.com> <30fd23ae-7035-5ce3-5643-89a5956f1e79@cybernetics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30fd23ae-7035-5ce3-5643-89a5956f1e79@cybernetics.com> X-Stat-Signature: 9wg49qukr1fobgfb9zm157giwqkcti1e Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JjPa68gO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 51A4C160055 X-HE-Tag: 1654033210-519764 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 31, 2022 at 02:22:21PM -0400, Tony Battersby wrote: > +static void pool_free_page(struct dma_pool *pool, > + struct dma_page *page, > + bool destroying_pool) 'destroying_pool' is always true, so I don't think you need it.