From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC4DCC433F5 for ; Tue, 31 May 2022 17:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62E946B0072; Tue, 31 May 2022 13:11:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DCB16B0073; Tue, 31 May 2022 13:11:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ED9E6B0074; Tue, 31 May 2022 13:11:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D28B6B0072 for ; Tue, 31 May 2022 13:11:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 00DD412127B for ; Tue, 31 May 2022 17:11:15 +0000 (UTC) X-FDA: 79526678952.11.5564FC2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 6DD5F400E2 for ; Tue, 31 May 2022 17:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xmTyJT+5kIE/+Ti/zVBhDjC/94/4cF7kWzPyVM3S4EI=; b=dOc7FimXhSvX3TCD4MTKnTQaUj 20Hi2phwf4Qio0ncLC5Zi+rQ6ijP5yFz5AoOuaLCFWJLx4GuOVzgZuOkQJw2tX88h9IpW9cDsLw6w 5D+hEErDv4yyerHuOD5lbFG0rZxX/p6dDbNIN3TTIgtPxXqflXOw6SJI6gg94k7ROzld9DWo+1LeE G2TTAzbcbaytOABHULJBEqDR+D+fKzef6qJC8U/zxiR7dL0cATRnATuDKFORTXfdV5+XpQNpX6f7b r/FLhVgDBrnPxvr1iJVsTa7a4cVO7tQQujn6XB03i/Cf6od/ZsA0sEfgYu2lVauagrIIJl6+NT16n OBrk02sQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw5OW-005YPg-7E; Tue, 31 May 2022 17:11:00 +0000 Date: Tue, 31 May 2022 18:11:00 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: linux-mm@kvack.org Subject: Re: [PATCH 3/6] mm/page_alloc: Export free_frozen_pages() instead of free_unref_page() Message-ID: References: <20220531150611.1303156-1-willy@infradead.org> <20220531150611.1303156-4-willy@infradead.org> <2a3cc8fa-72e0-021f-8849-2641ae85f68b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a3cc8fa-72e0-021f-8849-2641ae85f68b@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6DD5F400E2 X-Stat-Signature: ihwoei71mfnpx4phks6oxjj4y1tgia4m Authentication-Results: imf27.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=infradead.org header.s=casper.20170209 header.b=dOc7FimX; spf=temperror (imf27.hostedemail.com: error in processing during lookup of willy@infradead.org: DNS error) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1654017060-975615 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000151, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 31, 2022 at 07:09:09PM +0200, David Hildenbrand wrote: > On 31.05.22 17:06, Matthew Wilcox (Oracle) wrote: > > +++ b/mm/swap.c > > @@ -103,7 +103,7 @@ static void __put_single_page(struct page *page) > > { > > __page_cache_release(page); > > mem_cgroup_uncharge(page_folio(page)); > > - free_unref_page(page, 0); > > + free_frozen_pages(page, 0); > > } > > > > static void __put_compound_page(struct page *page) > > > IIUC, the net change is 0, because we'll always take the > pcp_allowed_order() path due to order==0, correct? Correct