From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3263C433F5 for ; Tue, 31 May 2022 02:26:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 589E76B0073; Mon, 30 May 2022 22:26:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 536146B0074; Mon, 30 May 2022 22:26:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D7C86B0075; Mon, 30 May 2022 22:26:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2AE8E6B0073 for ; Mon, 30 May 2022 22:26:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E3D1420390 for ; Tue, 31 May 2022 02:26:26 +0000 (UTC) X-FDA: 79524449172.21.E2773C2 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf20.hostedemail.com (Postfix) with ESMTP id 2961F1C0057 for ; Tue, 31 May 2022 02:26:08 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id q18so11648845pln.12 for ; Mon, 30 May 2022 19:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iv992blvs9Id0nKZNCQUi6AyK6qrkd7jCkuGgUWlqac=; b=QR9cp9SlXdxGFYBU5pilxQohbMBQAncS2IAUFL9MoT8gLdPyRrBdE+JmyHndh9OQDg rE6eeyc2jdsYk2vf0nYodiyQND1GTFmLwfIz41dLTveJWgyd3CRiZNPlWKe95h50CgOb RkmyOosMbRMZOCc6SduyD1vr+umt926AfGjmNX3fAdC1o966UMdF7EL3yB8dzVPhnWnK QOIitl7ariGYpeYBouTPLGraZr9dAfwtV87t5xQWTCYYgzELw1Dd6chT0Ep55jLLPQGb nSjNqhXIjVYKR0yBFSi8ZH/T6jT+m5mGD+zwpyWgCHzM5v5oT6nIuxtXCbS6PebIy8fn IO6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iv992blvs9Id0nKZNCQUi6AyK6qrkd7jCkuGgUWlqac=; b=3ueZf1csCj6fsmUt7XOOv64dYPchIMd1G9CPzgJkfPrUgXS6Zc/qL2oyf+T1PFKaVT BVgN7k9CHaTLxhfg+Y5io6FBFXxPeNyh//uvcMIIS+YG1brHX9e+55at9M4Qjrs0NA2I bIdD98tggq5y6rS15cEraAFNoF9jOM6xV1zy/PfkwmGQ10BDC1Uwl6o4RPx8lNsxho1K RX20y6fVxwDGYn/PPPngZj1K6M5oBOy9+fnkHxThynKSsrXdxzD8VcZ66T49Vo18Cf2C efpkFuaqQc3PeLTMCx7/xB6NkjSEbb6DhkseSWHzqbuA4mNGrkpd0kgJZayS0RoNrqcm BdJA== X-Gm-Message-State: AOAM5339rthe6ZYFDtHziTRscjKpH23Ip46uSD8KnAknj9tDbORedObc nbnh9VzuBnuqcdDIrr61LfS+IA== X-Google-Smtp-Source: ABdhPJxql+2GeEsG4msK5T3pxATV3sQyqA9V46SO//3rJmNOET4DX8x9cLKmr+nDzWuV1Mg01Bi1WA== X-Received: by 2002:a17:90a:4093:b0:1e0:a6f4:ea1a with SMTP id l19-20020a17090a409300b001e0a6f4ea1amr26313423pjg.12.1653963984807; Mon, 30 May 2022 19:26:24 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:7163:3a36:783f:6d4a]) by smtp.gmail.com with ESMTPSA id q10-20020a638c4a000000b003fa321e9463sm9474506pgn.58.2022.05.30.19.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 19:26:24 -0700 (PDT) Date: Tue, 31 May 2022 10:26:17 +0800 From: Muchun Song To: Andrew Morton Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v5 00/11] Use obj_cgroup APIs to charge the LRU pages Message-ID: References: <20220530074919.46352-1-songmuchun@bytedance.com> <20220530141711.6cf70dcf200e28aa40407f6e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220530141711.6cf70dcf200e28aa40407f6e@linux-foundation.org> Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=QR9cp9Sl; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf20.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2961F1C0057 X-Stat-Signature: isrhuehbpdjhxp48ai9mw1xikfdrnf37 X-HE-Tag: 1653963968-414431 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002888, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 30, 2022 at 02:17:11PM -0700, Andrew Morton wrote: > On Mon, 30 May 2022 15:49:08 +0800 Muchun Song wrote: > > > This version is rebased on v5.18. > > Not a great choice of base, really. mm-stable or mm-unstable or > linux-next or even linus-of-the-day are all much more up to date. > I'll rebase it to linux-next in v6. > Although the memcg reviewer tags are pretty thin, I was going to give > it a run. But after fixing a bunch of conflicts I got about halfway > through then gave up on a big snarl in get_obj_cgroup_from_current(). > Got it. Will fix. > > RFC v1: https://lore.kernel.org/all/20210330101531.82752-1-songmuchun@bytedance.com/ > > Surprising, that was over a year ago. Why has is taken so long? > Yeah, a little long. This issue has been going on for years. I have proposed an approach based on objcg to solve this issue last year, however, we are not sure if this is the best choice. So this patchset stalled for months. Recently, this issue was proposed in LSFMM 2022 conference by Roman, consensus was that the objcg-based reparenting is fine as well. So this patchset has recently resumed. Thanks.