From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB69C433F5 for ; Mon, 30 May 2022 15:04:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 254BB6B0071; Mon, 30 May 2022 11:04:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DC1B6B0072; Mon, 30 May 2022 11:04:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 053F96B0073; Mon, 30 May 2022 11:04:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E58E86B0071 for ; Mon, 30 May 2022 11:04:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id BDA7C80363 for ; Mon, 30 May 2022 15:04:30 +0000 (UTC) X-FDA: 79522730700.06.A71CAF0 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf31.hostedemail.com (Postfix) with ESMTP id 778492006E for ; Mon, 30 May 2022 15:03:50 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id y199so10783241pfb.9 for ; Mon, 30 May 2022 08:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HQ1N4ofCE0FRNNVNz7Ejwc9uv4RLnDojLdDFtHXcOM0=; b=UOHCjQRYQOJ0d8oQ+coX3IGMta5po6IRFVkKXGGERa09qLlnww35pEhAE8RFYrvNEh g7dl3TBpN01zrH5w5Zvj/2osjLNrGYpnrF9cEuKJeUXwkLw/zFQKawreydVtAfmquOS7 pEQ9G6R2UHElwNduZlhMaxByqfcylwAddIOiNAmxaZUSJdz731a33yBDZaNPZGCG95NC BEyraIJD/cZIDOFfNMSocvxckFWaPV2m0vem4wSHCyuSyKvVoshHU98nZTlvuOrRBj0/ uVu9qLUcJ/D8TMv/L6Pssqa/NsNKCjJOaM0Nj3hQ1oM47X9rz7ZFyURx+hREhnYIxMZl TQ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HQ1N4ofCE0FRNNVNz7Ejwc9uv4RLnDojLdDFtHXcOM0=; b=eN+Ul+SO0NO4dJVWdLNuvtO9i7ZEWiJ9NGddMeGB4urt4hmufLxPMfgqj4Y06yKiRd w48L9IN/R0e8W5gZ/ILTUxrH0OGeJuOnbroFWcqKuqgP/MMaUgOfB+fEgUBO8RdV580I E2K0SnYiaZPcvHf4dfHSG1PPl8MIXikU1Xs0ZoCUIgWBWZIoT2qVmLXQZsIXii7fK8c+ uTuTeF/wr5ku3loGJ3ynpqAWJh62IEsQpG6PbOA5RxkQMxE6n1o2XnnrOQZc2szRkiGD e2Vnqni8WhwAdbxQ7FKJEupfqDdjP1a/9hA35NRYGsfV+mE8s89OFpISmjB2YHPXoUZl 2aUg== X-Gm-Message-State: AOAM532UJndoVcSTSS70Pf0l9hovPuDgyfmk2cVecNPyCoNM2qZYb9xX OLCm/BwZsjh6yHpcA3wLTG74Bg== X-Google-Smtp-Source: ABdhPJx8IDuNFYLfdmyWIjTqL/G5fyCSXwYWny/jWfJoXNed1Z33IwfQHJWhlx+y7KmjBv/Hrqwi+Q== X-Received: by 2002:a62:e819:0:b0:518:6a98:b02 with SMTP id c25-20020a62e819000000b005186a980b02mr50782621pfi.74.1653923068523; Mon, 30 May 2022 08:04:28 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:2071:e13a:8aa:cacf]) by smtp.gmail.com with ESMTPSA id p6-20020a62ab06000000b0051843980605sm8908344pff.181.2022.05.30.08.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 08:04:28 -0700 (PDT) Date: Mon, 30 May 2022 23:04:21 +0800 From: Muchun Song To: Vasily Averin Cc: Andrew Morton , kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , Michal =?iso-8859-1?Q?Koutn=FD?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org Subject: Re: [PATCH mm v3 6/9] memcg: enable accounting for percpu allocation of struct cgroup_rstat_cpu Message-ID: References: <06505918-3b8a-0ad5-5951-89ecb510138e@openvz.org> <2fbede88-6ef7-4ce7-b3a3-ec349bc2cc06@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fbede88-6ef7-4ce7-b3a3-ec349bc2cc06@openvz.org> X-Stat-Signature: roifmc568tm38131c5khcqbromk3yxwp Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=UOHCjQRY; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf31.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 778492006E X-HE-Tag: 1653923030-134929 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 30, 2022 at 02:26:36PM +0300, Vasily Averin wrote: > struct cgroup_rstat_cpu is percpu allocated for each new cgroup and > can consume a significant portion of all allocated memory on nodes > with a large number of CPUs. > > Common part of the cgroup creation: > Allocs Alloc $1*$2 Sum Allocation > number size > -------------------------------------------- > 16 ~ 352 5632 5632 KERNFS > 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) > 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) > 1 192 192 10504 (__d_alloc+0x29) > 2 72 144 10648 (avc_alloc_node+0x27) > 2 64 128 10776 (percpu_ref_init+0x6a) > 1 64 64 10840 (memcg_list_lru_alloc+0x21a) > percpu: > 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e > 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f > 2 12 24 312 call_site=percpu_ref_init+0x23 > 1 6 6 318 call_site=__percpu_counter_init+0x22 > > '+' -- to be accounted, > '~' -- partially accounted > > Signed-off-by: Vasily Averin Acked-by: Muchun Song Thanks.