From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA1AC433F5 for ; Mon, 30 May 2022 05:04:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CAFA8D0002; Mon, 30 May 2022 01:04:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 575ED8D0001; Mon, 30 May 2022 01:04:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4645E8D0002; Mon, 30 May 2022 01:04:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 38ACB8D0001 for ; Mon, 30 May 2022 01:04:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 029B133C84 for ; Mon, 30 May 2022 05:04:00 +0000 (UTC) X-FDA: 79521217482.25.E52E062 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf30.hostedemail.com (Postfix) with ESMTP id A16B180053 for ; Mon, 30 May 2022 05:03:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E03C01F37E; Mon, 30 May 2022 05:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1653887038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mt9ESQWdPN4Qvqe8W55b+0vSvSQfocvj6KdXxFfUoE0=; b=Cd4Vh7W9R5ntByBgZZmfCVHvoF9xBlkF6KpFzmgOqQjV7Gm5OE9GaBhOhSqDxMjyWWsYqM NpabE9eqC8Xrqj1gD4mmH6VGnK/1wyFV/sldmhRmoolMMzVIesfiFcIuEAhwp2jW+Lr+FC WZzWDBpDMw/s+dmowJdU7uS46RQB5t0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1653887038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mt9ESQWdPN4Qvqe8W55b+0vSvSQfocvj6KdXxFfUoE0=; b=LIbDLIsHm2WcJYc0l1/LbDi7GTk6CowrHQguo2whaNDTIOC9Og9Hb6lhUUAuH2kR9UeXxi jfFx6Ef3h2Y++2Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8859813A84; Mon, 30 May 2022 05:03:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oq35HD5QlGKcPwAAMHmgww (envelope-from ); Mon, 30 May 2022 05:03:58 +0000 Date: Mon, 30 May 2022 07:03:56 +0200 From: Oscar Salvador To: Anshuman Khandual Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/memory_hotplug: Drop 'reason' argument from check_pfn_span() Message-ID: References: <20220526021258.4030749-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526021258.4030749-1-anshuman.khandual@arm.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A16B180053 X-Rspam-User: X-Stat-Signature: uia8i13btuqmyh1qsz8sf3oijmqsb8b5 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Cd4Vh7W9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LIbDLIsH; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-HE-Tag: 1653887007-120400 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 26, 2022 at 07:42:58AM +0530, Anshuman Khandual wrote: > In check_pfn_span(), a 'reason' string is being used to recreate the caller > function name, while printing the warning message. It is really unnecessary > as the warning message could just be printed inside the caller depending on > the return code. Currently there are just two callers for check_pfn_span() > i.e __add_pages() and __remove_pages(). Let's clean this up. > > Cc: Oscar Salvador > Cc: David Hildenbrand > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Acked-by: Oscar Salvador > --- > Changes in V2: > > - Fixed typo in commit message > - Dropped using 'ret' to capture check_pfn_span() return value in __add_pages() > > Changes in V1: > > https://lore.kernel.org/all/20220525033910.3781764-1-anshuman.khandual@arm.com/ > > mm/memory_hotplug.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 416b38ca8def..3b24386e9276 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -220,8 +220,7 @@ static void release_memory_resource(struct resource *res) > kfree(res); > } > > -static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, > - const char *reason) > +static int check_pfn_span(unsigned long pfn, unsigned long nr_pages) > { > /* > * Disallow all operations smaller than a sub-section and only > @@ -238,12 +237,8 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, > min_align = PAGES_PER_SUBSECTION; > else > min_align = PAGES_PER_SECTION; > - if (!IS_ALIGNED(pfn, min_align) > - || !IS_ALIGNED(nr_pages, min_align)) { > - WARN(1, "Misaligned __%s_pages start: %#lx end: #%lx\n", > - reason, pfn, pfn + nr_pages - 1); > + if (!IS_ALIGNED(pfn, min_align) || !IS_ALIGNED(nr_pages, min_align)) > return -EINVAL; > - } > return 0; > } > > @@ -320,9 +315,10 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, > altmap->alloc = 0; > } > > - err = check_pfn_span(pfn, nr_pages, "add"); > - if (err) > - return err; > + if (check_pfn_span(pfn, nr_pages)) { > + WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1); > + return -EINVAL; > + } > > for (; pfn < end_pfn; pfn += cur_nr_pages) { > /* Select all remaining pages up to the next section boundary */ > @@ -518,8 +514,10 @@ void __remove_pages(unsigned long pfn, unsigned long nr_pages, > > map_offset = vmem_altmap_offset(altmap); > > - if (check_pfn_span(pfn, nr_pages, "remove")) > + if (check_pfn_span(pfn, nr_pages)) { > + WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1); > return; > + } > > for (; pfn < end_pfn; pfn += cur_nr_pages) { > cond_resched(); > -- > 2.20.1 > -- Oscar Salvador SUSE Labs