From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A6AC433EF for ; Sun, 29 May 2022 12:26:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D48098D0002; Sun, 29 May 2022 08:26:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF8168D0001; Sun, 29 May 2022 08:26:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBCEB8D0002; Sun, 29 May 2022 08:26:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AFF248D0001 for ; Sun, 29 May 2022 08:26:34 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6280C20877 for ; Sun, 29 May 2022 12:26:34 +0000 (UTC) X-FDA: 79518703908.08.BA335B1 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf24.hostedemail.com (Postfix) with ESMTP id A87C2180011 for ; Sun, 29 May 2022 12:26:19 +0000 (UTC) Received: by mail-io1-f51.google.com with SMTP id y8so8918468iof.10 for ; Sun, 29 May 2022 05:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xK/bSJWWO57y/psK8zSSr6zBXFAfYJUDBYthsrv52G4=; b=M93PIG9ayKy+6Azc6L8CI6zsYP+MRzLY9KFbbGJrUMpuQeiQuJn/28XWqfHiGINthA we1Ucd3Jp7QPsRrh33PjTkXbJ1wHwGVjNI0DCRKas+Qcy39+dA5Bdx8GMphLnUpOgt91 N4Im38BlPoa4gVygoGGRcRs/iI6RcKlkpq+S8RtFP0xumW1HWvE4/eviff9dJTSpl6/7 5TFJmY3cI0qGxupujKfCVhilDSLXHx4QoEd2cckK5IiRD6FQTJ7eIuhU021RtFxA+1FJ W6EIQWzoX73oPP5claIaF7X6fAOaD8eAC0/cRyMvcvBogxtO7V37uG1Iyu9WVf/XmIjM zNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xK/bSJWWO57y/psK8zSSr6zBXFAfYJUDBYthsrv52G4=; b=mRf7IwKLoOG2qCXCOO7cZkF4nUAMSfijDJxuP3QL2KyoSnchjZ5wqKqgD6vvHmPlYt I1CPlpCYelqSBW3+TtyLdtqfZBDhN083pwLkOj0osIRQQclFoXowUgJ2LD0YPJ8k8oh0 VjmjZb/HnQkHuxXTY2vkgC2/06BaBLuznoTeFeuP7cEYZfgPpkr8NM15c6gjnxg/acZD 19ZveXSLuQYxC7KbHhcCjs0M19e1yLohJpe0bSg1T/jGI+2uF6h1Ft5nUUALt7r+uMae SWxzBlPB0Ju5hAnkcylRTMzLGc8y7huUDpbJi+CS0WCofIkpcmOUlNrUkpHl7o5kKgbi RLPg== X-Gm-Message-State: AOAM530VuJh4bsoYHLRoTVq8pb+2AoFoTS8U0wuYGxZgNrl4JfZ44sDv OiC1WR8URsBoFwFIcHQ28OI= X-Google-Smtp-Source: ABdhPJwS+WcNE9pbiOQSHZkVimE1O6GXPuUjlvKerJFqa4n34PQkSGx/DvTc1/2cTz2lidEh/SkA3w== X-Received: by 2002:a5d:9854:0:b0:65a:fb17:76c9 with SMTP id p20-20020a5d9854000000b0065afb1776c9mr22459984ios.37.1653827193103; Sun, 29 May 2022 05:26:33 -0700 (PDT) Received: from n2.us-central1-a.c.spheric-algebra-350919.internal (151.16.70.34.bc.googleusercontent.com. [34.70.16.151]) by smtp.gmail.com with ESMTPSA id z7-20020a6be007000000b0065dc93eae5dsm2594517iog.7.2022.05.29.05.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 May 2022 05:26:32 -0700 (PDT) Date: Sun, 29 May 2022 12:26:30 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Rongwei Wang Cc: akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm/slub: improve consistency of nr_slabs count Message-ID: References: <20220529081535.69275-1-rongwei.wang@linux.alibaba.com> <20220529081535.69275-2-rongwei.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220529081535.69275-2-rongwei.wang@linux.alibaba.com> X-Rspam-User: X-Rspamd-Queue-Id: A87C2180011 X-Stat-Signature: ct81obz6fo5br85ykpy7btssru9jjhs1 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=M93PIG9a; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1653827179-879509 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 29, 2022 at 04:15:34PM +0800, Rongwei Wang wrote: > Currently, discard_slab() can change nr_slabs count > without holding node's list_lock. This will lead some > error messages print when scanning node's partial or > full list, e.g. validate all slabs. Literally, it > affects the consistency of nr_slabs count. validate attribute is for debugging purpose. I did not take much time for this series but My quick impression is that it would be better to deprecate the attribute than making it work by affecting allocation/free path. Thanks, Hyeonggon.