From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2769C433F5 for ; Sun, 29 May 2022 02:58:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D13C48D0003; Sat, 28 May 2022 22:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C77AF8D0001; Sat, 28 May 2022 22:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3D3B8D0003; Sat, 28 May 2022 22:58:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A32258D0001 for ; Sat, 28 May 2022 22:58:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 8946F60554 for ; Sun, 29 May 2022 02:58:25 +0000 (UTC) X-FDA: 79517272170.28.A40DEED Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf02.hostedemail.com (Postfix) with ESMTP id 6F54680048 for ; Sun, 29 May 2022 02:58:20 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id n8so7482876plh.1 for ; Sat, 28 May 2022 19:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xqZyFR77LZa5HhEYDYSFVBgW+mJdeOilKX5Bk1mPIAU=; b=c8lMNY/sSIphdNiJshAYMu1CqUjbD5PanBJG75iQdDbbSaL+tBEsMNufhxMbyMmLq9 S6I3H22KxlNT+gAJkNrkj6Bz0b16LryVW0uLjqQqQTSnundCo/WIqxpvHttLS/ACJfLJ HVLY3NDiSnjjB5erjgkc8B3XunjQa7waGRcwPiLNAXldXON1Fk1mbG1Dp3dymRnZ6tjn 8zVpsbRj7VGyqBKb7jNxV70lfvZxznUS0G8RwR8IzMrj0uV+qiiJQepoHH0r2Xm03TSU J2H/kBaD+5EmHU0V97btF9mL0slO+zMalJunTAkzK7WsPs+AjvE1QDElNKacsjg+omgK P1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xqZyFR77LZa5HhEYDYSFVBgW+mJdeOilKX5Bk1mPIAU=; b=wsPNcvOwe4ikOpJUUQeN3xCP12Fi+PplpoCr8hrJhj7AJ7c/nTFpcXgxVgPKjcu364 Via0C4E9bQvJDAIFDP58Yk7A3y+/mobMSCDGcfEAJDmfByV8PAuQI/nxRh/MIrbjC+0Q n+Oxl/8JELEPt5WqgOiATQBcVa0rqTF3CpXO/z+MCBIsihhSH2jWOY105ry2STnIHw1h 7w44iFnDsGMWf2oInCtmEdqqzoFEhgZ5SCsG6sMymAUj/rFx7fjrjrE8rnPSgJ/+h2HS fJeWhcO8p5yAiTDKlCgQY3h+i2IDxKD3gR6Hun1Q8NlBxkUqaIqnN7/CoKDmVokuZZuI CIhA== X-Gm-Message-State: AOAM531Vg4nRyzVmfwA3DOkbTIkiG3eD96q334qnEO3G+v/lTPaRoJVQ 75hS+o/HVds28VTBwPNCUrd+/A== X-Google-Smtp-Source: ABdhPJxWGC7LKAf8hQu669+YBA7+lPsqdEug+mNQnYOi/nQ9+B3jLHYf5/agGPl5H68pJ9yL/Vvvrg== X-Received: by 2002:a17:903:209:b0:161:7f66:b9e0 with SMTP id r9-20020a170903020900b001617f66b9e0mr33873163plh.73.1653793103197; Sat, 28 May 2022 19:58:23 -0700 (PDT) Received: from localhost ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id c20-20020a170902c2d400b001637704269fsm1974580pla.223.2022.05.28.19.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 19:58:22 -0700 (PDT) Date: Sun, 29 May 2022 10:58:18 +0800 From: Muchun Song To: Matthew Wilcox Cc: bh1scw@gmail.com, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: replace alloc_pages with folio_alloc Message-ID: References: <20220528161157.3934825-1-bh1scw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6F54680048 X-Stat-Signature: 5874axtgx6zg4ierbxdfy71u6twm5ow5 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="c8lMNY/s"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1653793100-591429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 28, 2022 at 05:27:11PM +0100, Matthew Wilcox wrote: > On Sun, May 29, 2022 at 12:11:58AM +0800, bh1scw@gmail.com wrote: > > From: Fanjun Kong > > > > This patch will use folio allocation functions for allocating pages. > > That's not actually a good idea. folio_alloc() will do the > prep_transhuge_page() step which isn't needed for slab. > You mean folio_alloc() is dedicated for THP allocation? It is a little surprise to me. I thought folio_alloc() is just a variant of alloc_page(), which returns a folio struct instead of a page. Seems like I was wrong. May I ask what made us decide to do this? Thanks.