From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A507FC433EF for ; Fri, 27 May 2022 07:47:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E00B98D0005; Fri, 27 May 2022 03:47:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DACD98D0002; Fri, 27 May 2022 03:47:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9CE18D0005; Fri, 27 May 2022 03:47:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BCA478D0002 for ; Fri, 27 May 2022 03:47:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7E92B35AE5 for ; Fri, 27 May 2022 07:47:13 +0000 (UTC) X-FDA: 79510742346.12.39B8F0F Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf30.hostedemail.com (Postfix) with ESMTP id 862F280018 for ; Fri, 27 May 2022 07:46:41 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id v5-20020a17090a7c0500b001df84fa82f8so3668379pjf.5 for ; Fri, 27 May 2022 00:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2ldm8EWiIwlfTDrJygxjlJTr0fnRfKqWmoWrYzwj5Ms=; b=zORVVErp74/aJLOMVHlbo0nG2Xc2sgTAaQ4wQ/Mr1KMvBY/xep7hg2lsXDhmc/z7OL S3h5Wf2pKaXwukoWY2B1SdaYoOsnlOziQtDQ4tG4dWbXnWi7IY+dhK01saL5R8YnIsuf TvPukeDGWQWEUphXBKnsk70avh3a/Ju0rE1oi/2kYfV0dEg5IUn3+fcPlcD2/HsNmQO7 /dEdSncM+GEu3l4/pPugWgfoR7MZDoYdcCm3IwS5oTLkQsGn2Q/jNnPPlWH1E7IpjlnR wOZ64/sKJTBa25heB4MvMJ8ZLMvVgCJ4reiDdKgyZCbd7DSYVce8qP51sLf7BAkFM6XY UCxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2ldm8EWiIwlfTDrJygxjlJTr0fnRfKqWmoWrYzwj5Ms=; b=hgqxBXo0y5yT9vAyUj6u2pOFUgE8gruSTIIFNc7BfaoS0LZjCodJBxRL9721cbYsCf gs/AePP++3wvpBR8Hv9DRHpLIyIOyYj8aC8rVA/cJVZ/mQ84TEgIhIiwQqM9LeDgDVtO /THoEalPm6QpUR6IBfMo0XxYiQYeH6TDBjSGP6CmpM/XfjQWaswGzk+VlrBWYmPcJhFR E2GshnbYvtJ/6X77pUAE8zYVhelxmVnnPR17rmd+iOzc9wsN9pBh3WldNSCsmdTUXSG5 ndvsl3N7h5gYkZNydtM/o9QYcEcgAYzg7oVLRLMhqhisCmnV1+KOQigKu/t3PB2PMd5I R6Zw== X-Gm-Message-State: AOAM5302s1Cb/8JZMNemwflA4P4M9ypyoDZrxaou9YOrAZCjrBL9+8se z7+zlRGXf68xMC3apUzefZxpWA== X-Google-Smtp-Source: ABdhPJx3vE73dYEeKbsUD6iX5Y76xhiEjlK9ILC5gmBeKPv+KlLx5FCNqceTefulVNS9gSn8ndwwYw== X-Received: by 2002:a17:902:b193:b0:158:c040:5cf8 with SMTP id s19-20020a170902b19300b00158c0405cf8mr41802475plr.146.1653637630950; Fri, 27 May 2022 00:47:10 -0700 (PDT) Received: from localhost ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id jc12-20020a17090325cc00b00161996b9a66sm2890596plb.233.2022.05.27.00.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 00:47:10 -0700 (PDT) Date: Fri, 27 May 2022 15:47:04 +0800 From: Muchun Song To: Vlastimil Babka Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP* Message-ID: References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 862F280018 X-Stat-Signature: 5zn9ruw6o19hh35dpa956y5qdwyuyz85 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=zORVVErp; spf=pass (imf30.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam09 X-HE-Tag: 1653637601-541823 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 27, 2022 at 09:39:41AM +0200, Vlastimil Babka wrote: > On 4/4/22 09:46, Muchun Song wrote: > > --- a/mm/hugetlb_vmemmap.c > > +++ b/mm/hugetlb_vmemmap.c > > @@ -188,7 +188,7 @@ > > #define RESERVE_VMEMMAP_NR 1U > > #define RESERVE_VMEMMAP_SIZE (RESERVE_VMEMMAP_NR << PAGE_SHIFT) > > > > -DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON, > > +DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON, > > hugetlb_optimize_vmemmap_key); > > EXPORT_SYMBOL(hugetlb_optimize_vmemmap_key); > > Hi, > > looks like just below here you forgot to update: > > static enum vmemmap_optimize_mode vmemmap_optimize_mode = > IS_ENABLED(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON); > Good catch! > so it refers to CONFIG name that no longer exists? > Right. My bad. I forgot to replace it. Will fix it ASAP. Thanks.