From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1668C43334 for ; Tue, 7 Jun 2022 09:50:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C24C68D000E; Tue, 7 Jun 2022 05:50:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD3BF8D0001; Tue, 7 Jun 2022 05:50:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9B178D000E; Tue, 7 Jun 2022 05:50:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B1568D0001 for ; Tue, 7 Jun 2022 05:50:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6710C60E94 for ; Tue, 7 Jun 2022 09:50:01 +0000 (UTC) X-FDA: 79550968602.27.B6EBFBC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id DCA7F10000E for ; Tue, 7 Jun 2022 09:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=V51MCqxi0VdJWmnfuDPQt2vBU7orKrYz4MHoXseJ8Uc=; b=lpBAKPfTbALftwi2xeDgAO3ehh 89/3lBrHiHenx6805RN9wWVwR3WhentuV2zuMFLZyWzx6wnUf0UcqRmi66uhJGFL6A8zCCbvQ5lm2 MqIKPjcdNJ2gcBkeKiEj4YQOntFHTsoDxkRaYLNPVjuf+Iki8zNhngnEIW02e0f21yrm51zN19mjK PPqfLGM1llNlEftGJkJ9sHwEqnPbaGBWZJ0MtqdZ0XxBfpR4XPlxQygkJ9J6uTXDCgdNBhN4yJpDs ZkOtNBLFB8gyoIJqtjHbE4PIR8fRskJgZn8cgxKR54IZUpGY7JQ/+4VX7SLuEXK8BKzWdr3OgoYqH oPA5AwcQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyVqY-006P3h-8g; Tue, 07 Jun 2022 09:49:58 +0000 Date: Tue, 7 Jun 2022 02:49:58 -0700 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 2/5] mm/vmalloc: Extend __alloc_vmap_area() with extra arguments Message-ID: References: <20220607093449.3100-1-urezki@gmail.com> <20220607093449.3100-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607093449.3100-3-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=lpBAKPfT; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+f6762cbfc7881e849a3b+6862+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f6762cbfc7881e849a3b+6862+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: ttg9hgnw4h639ca4x3eppk6zcctp1c69 X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DCA7F10000E X-HE-Tag: 1654595361-174480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 07, 2022 at 11:34:46AM +0200, Uladzislau Rezki (Sony) wrote: > It implies that __alloc_vmap_area() allocates only from the > global vmap space, therefore a list-head and rb-tree, which > represent a free vmap space, are not passed as parameters to > this function and are accessed directly from this function. Yes, which totally makes sense. > Extend the __alloc_vmap_area() and other dependent functions > to have a possibility to allocate from different trees making > an interface common and not specific. Which seems completely pointless. Why add argument that are always passed the same values?