From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7165C433EF for ; Tue, 7 Jun 2022 07:53:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4567B6B0072; Tue, 7 Jun 2022 03:53:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 405A46B0073; Tue, 7 Jun 2022 03:53:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F4696B0074; Tue, 7 Jun 2022 03:53:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 204ED6B0072 for ; Tue, 7 Jun 2022 03:53:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E4F4E34FC7 for ; Tue, 7 Jun 2022 07:53:21 +0000 (UTC) X-FDA: 79550674602.06.628B8DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 85E5940077 for ; Tue, 7 Jun 2022 07:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654588400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kIeoNALdguR3aN7GKFEd9K9npyp4og2Qegkqr3lDxJQ=; b=Ya1jsPoWKA1hNsjlyikiBLTgftNRn5qSlkvz2+jsWq78B61SiCkEi7v5Epphx9Y4pC9/ax f75Gdc1PcvflWUwH3GJfdfWa4d7AmxescOWBCVSkPdckSp+Cea1gs0OippiMSG/II7uELk aXWqJ1AcsO7Q3cCBggrQsw1GBfnV5QU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-600-nAeEfYI2Mluw13Zq_E6HMQ-1; Tue, 07 Jun 2022 03:53:15 -0400 X-MC-Unique: nAeEfYI2Mluw13Zq_E6HMQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A56A73C0CD44; Tue, 7 Jun 2022 07:53:14 +0000 (UTC) Received: from localhost (ovpn-13-113.pek2.redhat.com [10.72.13.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6B47405D4BF; Tue, 7 Jun 2022 07:53:13 +0000 (UTC) Date: Tue, 7 Jun 2022 15:53:10 +0800 From: Baoquan He To: Christoph Hellwig Cc: akpm@linux-foundation.org, npiggin@gmail.com, urezki@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mm: ioremap: rename ioremap_page_range() to ioremap_range() Message-ID: References: <20220606083909.363350-1-bhe@redhat.com> <20220606083909.363350-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 85E5940077 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ya1jsPoW; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of bhe@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=bhe@redhat.com X-Stat-Signature: aguxhf5o47h6chh7e7wuzcadaixkzt8s X-Rspam-User: X-HE-Tag: 1654588354-568205 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/06/22 at 10:27pm, Christoph Hellwig wrote: > On Mon, Jun 06, 2022 at 04:39:09PM +0800, Baoquan He wrote: > > Because the current ioremap_page_range() only maps IO address to kernel > > virtual address, no struct page pointer passed in or page handling related. > > So rename it here. > > > > The renaming is done with below command: > > sed -i "s/ioremap_page_range/ioremap_range/g" `git grep -l ioremap_page_range` > > This creates a lot of churn without much of a benefit. If you want > to get rid of the name please convert most architectures to the > generioc ioremap code first so that all these callers go away.. Thanks for checking. Yeah, I didn't manually adjust those indentation after replacing via command. While the name of ioremap_page_range() is misleading, relative to its implementation. Converting to use generic ioremap code on most of architectures sounds like a good idea, just like what the arm/arm64 converting patchset is doing. From a quick look, not all places can take the converting, and there's one in pci_remap_iospace() under drivers. So what I need to do is to: 1)take back this pach; 2)convert as many architectures to the generic ioremap code as possible; 3)rename the left places of ioremap_page_range() to ioremap_range(). Please check if this is what you are suggesting. Thanks Baoquan