From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BB6C43334 for ; Mon, 6 Jun 2022 09:39:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 073398D0001; Mon, 6 Jun 2022 05:39:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0070C6B0073; Mon, 6 Jun 2022 05:39:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB45C8D0001; Mon, 6 Jun 2022 05:39:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C9A326B0071 for ; Mon, 6 Jun 2022 05:39:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 8463E12062B for ; Mon, 6 Jun 2022 09:39:56 +0000 (UTC) X-FDA: 79547314392.26.FAD340F Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf16.hostedemail.com (Postfix) with ESMTP id 962E218001A for ; Mon, 6 Jun 2022 09:39:36 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id 129so12490727pgc.2 for ; Mon, 06 Jun 2022 02:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZoeV4tpcFdbN8cau8WOm9bOYECWG4+biTPw4i5J/3P8=; b=5yjzNsesxMGmNfJnJ4tpJUll04Yw4Yc9v9h+QsYbnuKONz1XVn6mc1V3WiwyBYHLOP qRQlBMI7alp6/Nqt3j9irOOOMAItDxCXrWXUIdSSRwnu2joAbd77aSFWaZ/If4my/P6c b+ujnJpXa2sobCW2MeHMQfUtkyVsJNtIDiMmu4qpvJtwK2gmuFFo2IsZwBWV4mJzY+H6 bemXPyE2S3KomEYaIOEVnsI12GcUID5NXHRem6ilHHIQX0fxt61jHJgJnK9uy0z3n0l1 03kxTPz96bRjKHXtKsMzDyOCw43acft+E2a7HGHpF38ZmYyMsI9rTkgnrvwKOC05sBB5 UG9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZoeV4tpcFdbN8cau8WOm9bOYECWG4+biTPw4i5J/3P8=; b=Hlm7uN8lDt8+SSzEVrkHTlp5uTpz3GdGqa1GYp0BAU4unybw2yY14npwYnszNaJxlh 4skkGpa/VmxEL6ldBTrObykV2c/yBKxocpjfyfc7tu+cFSLUA1XOPHm3dkr4WL6TVwyU GpKOHiTtyeX/OL6nUfgKUFi7JAtIRgmSdI2qFpyBVZQbCndcWGv7L6jMLdn5/xPNh6AQ DcOcf98Q/zlIkHq3M+UlEXHXk6tCT8zazJYBm0lXgCv5RtuIHJk1TWEMGOuTUFRS8Yov jE2YdgybHiCM3/Lr476zYAT4kz0dzXXV2v/MRUf0GihGxpXtBtuw4xQtgr13kSLBHLkk Oa/g== X-Gm-Message-State: AOAM532ClPce9g/G2frbsYlz6KsA1SGOqI55mhE1NcQi26rqCWvL/Ej2 texjpVFKugbRGCet90RrnsBh7w== X-Google-Smtp-Source: ABdhPJy0FzNarVYUzkqKZm1/7nlsZc28TsYmoPhH7gv+7167cTq2V4jCaUHHN5ZlL4rTv9ws4CEcHg== X-Received: by 2002:a63:8bc7:0:b0:3fc:b8ab:c612 with SMTP id j190-20020a638bc7000000b003fcb8abc612mr20114114pge.535.1654508394026; Mon, 06 Jun 2022 02:39:54 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:7cb7:47eb:4eca:56f3]) by smtp.gmail.com with ESMTPSA id o4-20020a655bc4000000b003db610ebdd0sm10095283pgr.65.2022.06.06.02.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 02:39:53 -0700 (PDT) Date: Mon, 6 Jun 2022 17:39:48 +0800 From: Muchun Song To: Chen Wandun Cc: hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 1/3] mm/shmem: check return value of shmem_init_inodecache Message-ID: References: <20220606034530.153505-1-chenwandun@huawei.com> <20220606034530.153505-2-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606034530.153505-2-chenwandun@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 962E218001A X-Stat-Signature: xd84fesegg71kjs7peektznj6ea3o7bu Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=5yjzNses; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1654508376-461905 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 06, 2022 at 11:45:28AM +0800, Chen Wandun wrote: > It will result in null pointer access if shmem_init_inodecache fail, > so check return value of shmem_init_inodecache > > Signed-off-by: Chen Wandun > --- > mm/shmem.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 12d45a03f7fc..7419ab219b97 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3775,11 +3775,16 @@ static void shmem_init_inode(void *foo) > inode_init_once(&info->vfs_inode); > } > > -static void shmem_init_inodecache(void) > +static int shmem_init_inodecache(void) > { > shmem_inode_cachep = kmem_cache_create("shmem_inode_cache", > sizeof(struct shmem_inode_info), > 0, SLAB_PANIC|SLAB_ACCOUNT, shmem_init_inode); NACK, we cannot dereference a NULL pointer since SLAB_PANIC is passed to kmem_cache_create(). > + > + if (!shmem_inode_cachep) > + return -ENOMEM; > + > + return 0; > } > > static void shmem_destroy_inodecache(void) > @@ -3923,7 +3928,9 @@ void __init shmem_init(void) > { > int error; > > - shmem_init_inodecache(); > + error = shmem_init_inodecache(); > + if (error) > + goto out2; > > error = register_filesystem(&shmem_fs_type); > if (error) { > -- > 2.25.1 > >