From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECECBC433F5 for ; Tue, 24 May 2022 11:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F5728D0002; Tue, 24 May 2022 07:45:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A3018D0001; Tue, 24 May 2022 07:45:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4429E8D0002; Tue, 24 May 2022 07:45:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 306288D0001 for ; Tue, 24 May 2022 07:45:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E062034E18 for ; Tue, 24 May 2022 11:45:43 +0000 (UTC) X-FDA: 79500456966.17.9AE9874 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf02.hostedemail.com (Postfix) with ESMTP id B2D1780034 for ; Tue, 24 May 2022 11:45:40 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id p63so596870qkf.0 for ; Tue, 24 May 2022 04:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CR09yeXsFtoUOg9OMladANfYR85/7BwnLnQK+uR1N0Y=; b=fvqp9+cdKj6LUnqaiDF1ifg3kW67yhA7mfjWX6ZFH2sG5F8ll4k55tNdNMuoB1M4to Z1AV36+WHxVDjTPLY6bzHrbo5yJXPiJYOceulRYWs7upkmVU3JGKtI50rd0LWM/Pmo91 Z65P8xlljk+pDOkEJB58JvWaTZZdZ5QPbzT38ZFoJGHl/G+l2Jz7Limq9k4aafPrTBoO VQeW7Q/M2I8PndKg6WFmKst0Pc3oRyJmlwI0SCBvP/h9UWXS8S2mRljTo/QRrsFQH+/T 7FlXtbCY5LpzOlJWW9Vrj3DkOYOFXiz3oUu1znM50xY05BDXckQpGZUkOI6gWeA7kRD+ P8Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CR09yeXsFtoUOg9OMladANfYR85/7BwnLnQK+uR1N0Y=; b=sY6VsHPePJ9IOlBRj3xLF6z/sy9YV8U3x7ZQ7C6FvS17yz36f7upihwUesmk3m6GHo X0/vfRbPaclO0pufOkr3UrH1btubNO6srmNJ7KHooyLxnvXEB0QrU5cmUHhXy5SjnPhe BYqypLSPa5nZ96ipnAknGZ6Pa6zaFK8Z1vQrFwT5f0/67mMNpFeUmSgQDUfSrGyyH+PH DC3BvFWpX96E+9MuLikQPE1GgAyXEejr3D3x16GWDHrEwQLRdBGTtDM8wO7aY0iZ2AHH /7lJJQ7ejMLP2VS8EjPiHCFygfYVv7IpjpDMwBO03zHee75yA5B43Lg+6qo4MQ7TLWGq wu5w== X-Gm-Message-State: AOAM532TlBsPM0BvPQPRjOHeoBcJPDQk496knlHdejOqXLFOZ3lzk11e Dde0dIzwclRLLq5HaI96Gu+ufQ== X-Google-Smtp-Source: ABdhPJy+mRmOWARy6q76pkXL/ov/YwM3Sjk6bTK9qOTgTtk/PBNAMmayhuzsas+dwXg1UhhNSG9LBQ== X-Received: by 2002:a05:620a:bc6:b0:67c:ce55:d2d4 with SMTP id s6-20020a05620a0bc600b0067cce55d2d4mr17064770qki.175.1653392742579; Tue, 24 May 2022 04:45:42 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:741f]) by smtp.gmail.com with ESMTPSA id cg7-20020a05622a408700b002f9050bb622sm5988169qtb.69.2022.05.24.04.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 04:45:42 -0700 (PDT) Date: Tue, 24 May 2022 07:45:40 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Michal Hocko , Vaibhav Jain , Cgroups , linux-doc@vger.kernel.org, Linux Kernel Mailing List , Linux-MM , Tejun Heo , Zefan Li , Jonathan Corbet , Vladimir Davydov , Andrew Morton , "Aneesh Kumar K . V" , Shakeel Butt Subject: Re: [PATCH] memcg: provide reclaim stats via 'memory.reclaim' Message-ID: References: <20220518223815.809858-1-vaibhav@linux.ibm.com> <87zgjcg4xs.fsf@vajain21.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B2D1780034 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=fvqp9+cd; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Stat-Signature: upn84nhmymymuxtbgpsr3axegoyt6tad X-HE-Tag: 1653392740-598862 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 23, 2022 at 03:50:34PM -0700, Yosry Ahmed wrote: > I think it might be useful to have a dedicated entry in memory.stat > for proactively reclaimed memory. A case where this would be useful is > tuning and evaluating userspace proactive reclaimers. For instance, if > a userspace agent is asking the kernel to reclaim 100M, but it could > only reclaim 10M, then most probably the proactive reclaimer is not > using a good methodology to figure out how much memory do we need to > reclaim. > > IMO this is more useful, and a superset of just reading the last > reclaim request status through memory.reclaim (read stat before and > after). +1