From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7836AC433EF for ; Tue, 24 May 2022 15:20:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C23968D0003; Tue, 24 May 2022 11:20:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD2C18D0002; Tue, 24 May 2022 11:20:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABFB88D0003; Tue, 24 May 2022 11:20:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9934F8D0002 for ; Tue, 24 May 2022 11:20:12 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 65802215E4 for ; Tue, 24 May 2022 15:20:12 +0000 (UTC) X-FDA: 79500997464.31.26488E0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 6981340021 for ; Tue, 24 May 2022 15:19:42 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C8867B818FA; Tue, 24 May 2022 15:20:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0E6EC34113; Tue, 24 May 2022 15:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653405608; bh=IW3RND1D6FLNAz8IY81qq+Ng2PVrV4Y+5Y+V1m1ThxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ux22iTMayVuaz9NVAe02w7VtIXotOlPsjqbvrADuy8iUaURlY69yKXwTUc+fp+Oth WFIqvhQMCa1ithe+Nev2NIxnutxuP7ECqooUgFHrnS7zCWDx6ME59VkKbSGAJsskbI lcKoBOb+rtqF8UATejhz6YG1gzLi5tJ00511fgdLUIIVWxWRzu5aVSSDUoMLSRoLUa m5UakIt7GhReQ2v+G6WPt2ygiTqST5l79kLt973xfbmenlMpcizB99UlrGcsfdO3Lg vOq3JbiMM1hS2GjtXayUMFx+qjQz4qrX9Dv5vq6RPSjWvN5IXNbCkdK6TZ6DRZr623 nKC8A5jYQqu+A== Date: Tue, 24 May 2022 09:20:04 -0600 From: Keith Busch To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, linux-xfs@vger.kernel.org, Changhui Zhong Subject: Re: [PATCH V2] block: ignore RWF_HIPRI hint for sync dio Message-ID: References: <20220420143110.2679002-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6981340021 X-Stat-Signature: hnyomnem6oumrr773d8yhb4zqyqhfc4p Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ux22iTMa; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of kbusch@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kbusch@kernel.org X-Rspam-User: X-HE-Tag: 1653405582-394260 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 02:28:58PM +0800, Ming Lei wrote: > On Mon, May 23, 2022 at 10:34:27PM -0600, Keith Busch wrote: > > On Mon, May 23, 2022 at 09:02:39PM -0600, Keith Busch wrote: > > > Here's a bandaid, though I assume it'll break something... > > > > On second thought, maybe this is okay! The encoded hctx doesn't change after > > this call, which is the only thing polling cares about. The tag portion doesn't > > matter. > > I guess it still may change in case that nvme mpath bio is requeued. A path failover requeue strips the REQ_POLL flag out of the bio, so it would be interrupt driven at that point.