From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C7FC433F5 for ; Tue, 24 May 2022 06:29:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E59146B0074; Tue, 24 May 2022 02:29:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0AA58D0001; Tue, 24 May 2022 02:29:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1F4E6B0078; Tue, 24 May 2022 02:29:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C3E7F6B0074 for ; Tue, 24 May 2022 02:29:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9E62521436 for ; Tue, 24 May 2022 06:29:17 +0000 (UTC) X-FDA: 79499659554.12.4B8A9E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 4655E1C0029 for ; Tue, 24 May 2022 06:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653373754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QqprHMR4J1N37LkxbIvmjg3ysuuBkqBVL3+ix+BlY1g=; b=Xm2iZgGaYNgaQiS72PLRED0Es5uRi/Q0moiXlm30GUh7OlMC7JCAghz/q4WyLvMhAa55Md oBRWLxCI6D1kOUwGhqSp2ywmQwr5KLlAdczzzSWI+MkchhGcn1HqfmhtnD1F9RBgyTlfVQ NypcWvOIKdGPO+6v11xWuM2EeJvaWS4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-PDEnsvwLNzSxGqeuekoxkA-1; Tue, 24 May 2022 02:29:10 -0400 X-MC-Unique: PDEnsvwLNzSxGqeuekoxkA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CB09C80159B; Tue, 24 May 2022 06:29:09 +0000 (UTC) Received: from T590 (ovpn-8-17.pek2.redhat.com [10.72.8.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CAF8A1121315; Tue, 24 May 2022 06:29:04 +0000 (UTC) Date: Tue, 24 May 2022 14:28:58 +0800 From: Ming Lei To: Keith Busch Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, linux-xfs@vger.kernel.org, Changhui Zhong Subject: Re: [PATCH V2] block: ignore RWF_HIPRI hint for sync dio Message-ID: References: <20220420143110.2679002-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4655E1C0029 X-Stat-Signature: m4os3rui9cg8i63guw9tumr7hzro4iai Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xm2iZgGa; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of ming.lei@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=ming.lei@redhat.com X-Rspam-User: X-HE-Tag: 1653373740-730450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 23, 2022 at 10:34:27PM -0600, Keith Busch wrote: > On Mon, May 23, 2022 at 09:02:39PM -0600, Keith Busch wrote: > > Here's a bandaid, though I assume it'll break something... > > On second thought, maybe this is okay! The encoded hctx doesn't change after > this call, which is the only thing polling cares about. The tag portion doesn't > matter. I guess it still may change in case that nvme mpath bio is requeued. Thanks, Ming