linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	linux-mm@kvack.org, linux-xfs@vger.kernel.org,
	Changhui Zhong <czhong@redhat.com>
Subject: Re: [PATCH V2] block: ignore RWF_HIPRI hint for sync dio
Date: Tue, 24 May 2022 14:28:58 +0800	[thread overview]
Message-ID: <Yox7Kp2N1NzSes0C@T590> (raw)
In-Reply-To: <YoxgU5/P460FZ3rl@kbusch-mbp.dhcp.thefacebook.com>

On Mon, May 23, 2022 at 10:34:27PM -0600, Keith Busch wrote:
> On Mon, May 23, 2022 at 09:02:39PM -0600, Keith Busch wrote:
> > Here's a bandaid, though I assume it'll break something...
> 
> On second thought, maybe this is okay! The encoded hctx doesn't change after
> this call, which is the only thing polling cares about. The tag portion doesn't
> matter.

I guess it still may change in case that nvme mpath bio is requeued.


Thanks,
Ming



  reply	other threads:[~2022-05-24  6:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 14:31 Ming Lei
2022-04-21  7:02 ` Christoph Hellwig
2022-04-21 11:48 ` Changhui Zhong
2022-05-02 16:01 ` Ming Lei
2022-05-02 16:07 ` Jens Axboe
2022-05-23 22:36 ` Keith Busch
2022-05-24  0:40   ` Ming Lei
2022-05-24  3:02     ` Keith Busch
2022-05-24  4:34       ` Keith Busch
2022-05-24  6:28         ` Ming Lei [this message]
2022-05-24 15:20           ` Keith Busch
2022-05-24  6:10       ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yox7Kp2N1NzSes0C@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=czhong@redhat.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox