From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51883C433F5 for ; Mon, 23 May 2022 13:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0A186B0005; Mon, 23 May 2022 09:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B93086B0006; Mon, 23 May 2022 09:55:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A82FE6B0007; Mon, 23 May 2022 09:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 94AB86B0005 for ; Mon, 23 May 2022 09:55:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6356F61038 for ; Mon, 23 May 2022 13:55:18 +0000 (UTC) X-FDA: 79497154716.17.C5EDE9E Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf24.hostedemail.com (Postfix) with ESMTP id 4440B180026 for ; Mon, 23 May 2022 13:55:05 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id n8so13168441plh.1 for ; Mon, 23 May 2022 06:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Df9yWQ/aDxzNckvtabHN6S/25VXwYOsM+nyYbdaI3a8=; b=TzTbXf5jrW5oQ4yIsnoZCjia8f/YM/jmgfc1tLNqZmzCb3k08ZDczecDygA0fXzxW0 M81MuFj8NK6DtCT/7OVTIJAv3BhESb+ZGlV+g6JnG+cYwI4CMLm02QiKYbzV39WLLSMS komvx0Xcb0OjEcfD56VP8GFPwyRc8+XD62mjfdTjYLgCGwqfkwDFeTyxa0gvcwRln5V/ eppJDWhh1gIYIIsgZb6SvwT1JFJc8Rc2PSnfcYkaYqyCR0LGr7wqnJA8xusq60qOrKuG qGuAxRsk7r+MPmY10Dyd8BT8HZLGxWoTa7CzLg8N/e+uS1IVHCPP3SOQTgQY7OVwOhG9 40mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Df9yWQ/aDxzNckvtabHN6S/25VXwYOsM+nyYbdaI3a8=; b=CuOeWStfnGNrW5Y9t7qrSQ2jhggSckG1N5fJt7kHKZIuY3zBnDqJcAm8fJuDLRe+uG ghlJ2pVA9JlxqtCYojow2vPobCD92xK5xnJbmLtuCkcl9bMLMjXq2nYXuSBvVEjRIt/p KHaY6/OrgOkkpxwhn2iaH1sen8BIjHh2PsvNpEQ80WQIJnOET5wuQNkVLvuImFcmmApS O/ihC1EQMWeJ29xLwD10akjqkRVrmpmq9MVMu7j55f0ES4vyoYVBiXK6kr6CfLqoJFIR Ysk8lzDfAzgZsxcYfKqSF898SApGc9bKBKuWoEv3Tm1lvauQ1XSwaGEXiI3JGPL0EGk1 XKCg== X-Gm-Message-State: AOAM532r1QasVqG4O+cNFwWWYLgbCpM7k5JMm/zIGonGcAzbxYZZJace zGeDOXNlfxzoWhpR4KZzj9sH9w== X-Google-Smtp-Source: ABdhPJzTAKPyvsoV7ZaiJUcH3STTBACV6avvux7V/4Wgew6Anu+8+y7upkEqa6ojZ1VZGLBk9Poqrg== X-Received: by 2002:a17:902:a413:b0:156:15b:524a with SMTP id p19-20020a170902a41300b00156015b524amr23014244plq.106.1653314116404; Mon, 23 May 2022 06:55:16 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:2c28:f36b:423b:6bc6]) by smtp.gmail.com with ESMTPSA id a15-20020a170902eccf00b0016170bb6528sm5211384plh.113.2022.05.23.06.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 06:55:15 -0700 (PDT) Date: Mon, 23 May 2022 21:55:10 +0800 From: Muchun Song To: Christophe JAILLET Cc: dan.carpenter@oracle.com, Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Tejun Heo , Zefan Li , Shuah Khan , David Vernet , Andrew Morton , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] cgroup: Fix an error handling path in alloc_pagecache_max_30M() Message-ID: References: <628312312eb40e0e39463a2c06415fde5295c716.1653229120.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <628312312eb40e0e39463a2c06415fde5295c716.1653229120.git.christophe.jaillet@wanadoo.fr> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4440B180026 X-Stat-Signature: o65b7hg8qmzg4ukespfyaqbb4tcxr9nc X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=TzTbXf5j; spf=pass (imf24.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1653314105-786917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 22, 2022 at 04:18:51PM +0200, Christophe JAILLET wrote: > If the first goto is taken, 'fd' is not opened yet (and is un-initialized). > So a direct return is safer. > > Fixes: c1a31a2f7a9c ("cgroup: fix racy check in alloc_pagecache_max_30M() helper function") > Signed-off-by: Christophe JAILLET Acked-by: Muchun Song Thanks.