From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39349C433EF for ; Mon, 23 May 2022 06:46:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A845D6B0005; Mon, 23 May 2022 02:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A342E6B0006; Mon, 23 May 2022 02:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9499A6B0007; Mon, 23 May 2022 02:46:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8789E6B0005 for ; Mon, 23 May 2022 02:46:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5BECE30E00 for ; Mon, 23 May 2022 06:46:42 +0000 (UTC) X-FDA: 79496074644.22.2A9BE0B Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf25.hostedemail.com (Postfix) with ESMTP id 36EE0A000F for ; Mon, 23 May 2022 06:46:14 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id nk9-20020a17090b194900b001df2fcdc165so16676813pjb.0 for ; Sun, 22 May 2022 23:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=X0xImzKACB8xr09/1p2KiEMME+Z8nsRkoW03SWthovs=; b=pIbr7eUQbCyccrTY6kl4Mw0uIBAhCJJ7iKfyeriiihnYydpms/mvgVMVKtyY79E+He E2ocvu2fatYF83EFnUPXvrEocAHhtAI/R0H9t+g3JViDtpCWK9og0qRIs95oXPGwBJQJ qC5N5JouALPqHKFK7XkPZ+FZSt4YYxnNegkzvH96oXDomLJn5l1ZVQDHW8ElMeL/8Cxm 2/AxB09KjZTIcLKPm836LHxhna4GaLDsd2/xZrfCb5nA4TtHFK1JSaVgYr0wZfIuTHhA b/EAu2TOwQDjkQGikROa74N8nDjEu5hpEphWimJVZ6phwAXatVMN+dff4eANYU1pfkII EWQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X0xImzKACB8xr09/1p2KiEMME+Z8nsRkoW03SWthovs=; b=4aGwg2gZH1b/ObphvJXyKj4JvMOr1myojN6InkXVgkePXgyByk7rMt4it2GftDXUhN MIEqA+Kab6GiErW7ToI05eYzsdAfDleyBSyO1YbjlkaaZd7FdER6lpSMh30bL0YukArG SW2C7DED3eS1pG77wfZqPBMBFLvK7mCs5nrWM4UMgoXTnsc7Z7RMmNxOI1YZb9iiuELM aL5l0mhZqkHYyfZb5ZUJgsBL4u1H//yLnXW6pdLH6PkREfc1NnFNzPxADbEoidothYxI B8sRXaReLq8mAGMzDaZuTTzCXdy9kvDxqTBYHt+Ls0qDt/zgst6O/HcMflq/0imUXeQl hHXQ== X-Gm-Message-State: AOAM532QV7LFob1Zx78VpUCD/igzFbRzVWpupaGDNYVaXv/hbpS1nty5 MNIELMTlCloHLpu0V/d1Aub5Yg== X-Google-Smtp-Source: ABdhPJxy25Veknz7ZxzoH9X4XoH157uPXN4SJfhzuiiXoszq0QasEwNWgksr/fpqOe2gQVPT4ebPKQ== X-Received: by 2002:a17:902:b083:b0:161:e861:ebe3 with SMTP id p3-20020a170902b08300b00161e861ebe3mr17479939plr.7.1653288400112; Sun, 22 May 2022 23:46:40 -0700 (PDT) Received: from localhost ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id u18-20020a17090341d200b0015f2b3bc97asm4296153ple.13.2022.05.22.23.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 May 2022 23:46:39 -0700 (PDT) Date: Mon, 23 May 2022 14:46:36 +0800 From: Muchun Song To: Kefeng Wang Cc: Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , linux-mm@kvack.org, kasan-dev@googlegroups.com Subject: Re: [PATCH] mm: kfence: Use PAGE_ALIGNED helper Message-ID: References: <20220520021833.121405-1-wangkefeng.wang@huawei.com> <20d731fd-f7f9-4c93-d851-01972dc04cb9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20d731fd-f7f9-4c93-d851-01972dc04cb9@huawei.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 36EE0A000F X-Stat-Signature: 54h4cznoisbsr7hy4wtqn7nqcsxsqxfb X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=pIbr7eUQ; spf=pass (imf25.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1653288374-403849 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 23, 2022 at 02:32:59PM +0800, Kefeng Wang wrote: > > On 2022/5/20 18:26, Muchun Song wrote: > > On Fri, May 20, 2022 at 10:18:33AM +0800, Kefeng Wang wrote: > > > Use PAGE_ALIGNED macro instead of IS_ALIGNED and passing PAGE_SIZE. > > > > > > Signed-off-by: Kefeng Wang > > Acked-by: Muchun Song > Thanks, > > > > BTW, there is a similar case in page_fixed_fake_head(), woule you like to > > improve that as well? > > IS_ALIGNED is defined in include/linux/align.h, but PAGE_ALIGNED is in include/linux/mm.h, > so better to keep unchanged in include/linux/page-flags.h. > Maybe we could move this macro to page-flags.h or align.h so that we could reuse it? Thanks.