From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61524C433FE for ; Sun, 22 May 2022 21:54:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4BF88D0001; Sun, 22 May 2022 17:54:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DDF08D0008; Sun, 22 May 2022 17:54:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 625D08D0001; Sun, 22 May 2022 17:54:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4BFE28D0006 for ; Sun, 22 May 2022 17:54:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 7D9561208F8 for ; Sun, 22 May 2022 06:37:21 +0000 (UTC) X-FDA: 79492422282.18.655F8CD Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf15.hostedemail.com (Postfix) with ESMTP id 7DC66A0002 for ; Sun, 22 May 2022 06:37:02 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id l7-20020a17090aaa8700b001dd1a5b9965so11020789pjq.2 for ; Sat, 21 May 2022 23:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SS4jw3jE67JbDZTZdbjql/HYvYPNQbA1HjLNkPGV220=; b=tH30EpVK2h/cCwkIA89339RbASD9rwQYzV2mpWXdJeN1f2qCoMf0aw+zavoo/5g+Im szoe9euSzxHQzARGh9ChqS4tUPL1BtXXyt39qSSHWItE4nzGG4KjRDUi2GXIutzNildO wswdljmUZs04AM1qJeN5L4dR80f/jFVvYOfM+kYYqWqT1Gn6VtxFyeRCyxWMu8VVi9z4 rq9SjvSnZ7eSzbzO4IXPUb/T1UV/BGSnSzRpOKGBHaNJq5cqbp7YL4osznVW8jiRpg8k RS0QtL1EeAIbWz230hGs/rrOofuOszZl9MPmnt2Ei5ECuQJAasNZlslU1Q5OSQXKqKvf Pc3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SS4jw3jE67JbDZTZdbjql/HYvYPNQbA1HjLNkPGV220=; b=nkeUnNYJzbFKcoylpmhW/Lj+z1X21LmoIdZW8L79A/lVgCGCXQt25hPrzIuElFhFut ZdRmyYP6cvoBHB/rHVZv4JCTVlBxrjxBL0fdZ0pT3hNyt2GVQYMrbZpQOcBr2K2LZs9k rK2anFZVl1y+6pTbPa67Q8kwoERmRCKvWOKAnJr/uiYMrVj7bUeX1W2CKhjyD+wpEKQa GUr9Hjrmmj/qcu1LFmYv3I9QAyRz+bEEhNJ/uQAMopg5Q7l/jUKw2iCEJZMtuVwuUyb9 Tc9jrCJCGQIRLdan5LkvcVGfVejXZzlTMsBXNO4WxDO7lDOmfiOmYkHo29Ys2VRWerlN g5HA== X-Gm-Message-State: AOAM533vkjpdPYaA2yRuj2RjP4znen3XanMNzO2xT7pISRIWCXGWMpNe lX7dGnRz8zajreIgVvOh1ld1cpgdXb40wA== X-Google-Smtp-Source: ABdhPJwae3Oa4ZVDQNKMz6WWiYljvlfeozJ8gfOr2RQVSQpJHBcdMys7MiMD3hnmZRNK5ToinGGffw== X-Received: by 2002:a17:903:481:b0:161:6392:c350 with SMTP id jj1-20020a170903048100b001616392c350mr17482105plb.17.1653201439206; Sat, 21 May 2022 23:37:19 -0700 (PDT) Received: from localhost ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id l4-20020a17090a660400b001df666ebddesm4677245pjj.6.2022.05.21.23.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 23:37:18 -0700 (PDT) Date: Sun, 22 May 2022 14:37:14 +0800 From: Muchun Song To: Vasily Averin Cc: Andrew Morton , kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , Michal =?iso-8859-1?Q?Koutn=FD?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org Subject: Re: [PATCH mm v2 1/9] memcg: enable accounting for struct cgroup Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 7DC66A0002 X-Stat-Signature: g5z5gyoiky8y5npn9kuqk8bcodd553n1 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=tH30EpVK; spf=pass (imf15.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam03 X-HE-Tag: 1653201422-260741 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 21, 2022 at 07:37:36PM +0300, Vasily Averin wrote: > Creating each new cgroup allocates 4Kb for struct cgroup. This is the > largest memory allocation in this scenario and is epecially important > for small VMs with 1-2 CPUs. > > Common part of the cgroup creation: > Allocs Alloc $1*$2 Sum Allocation > number size > -------------------------------------------- > 16 ~ 352 5632 5632 KERNFS > 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) > 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) > 1 192 192 10504 (__d_alloc+0x29) > 2 72 144 10648 (avc_alloc_node+0x27) > 2 64 128 10776 (percpu_ref_init+0x6a) > 1 64 64 10840 (memcg_list_lru_alloc+0x21a) > percpu: > 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e > 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f > 2 12 24 312 call_site=percpu_ref_init+0x23 > 1 6 6 318 call_site=__percpu_counter_init+0x22 > > '+' -- to be accounted, > '~' -- partially accounted > > Accounting of this memory helps to avoid misuse inside memcg-limited > containers. > > Signed-off-by: Vasily Averin Reviewed-by: Muchun Song