From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B85A1C433EF for ; Sun, 22 May 2022 21:59:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 536A48D0002; Sun, 22 May 2022 17:59:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E7258D0001; Sun, 22 May 2022 17:59:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AF678D0002; Sun, 22 May 2022 17:59:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2A2848D0001 for ; Sun, 22 May 2022 17:59:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 1DBEF80751 for ; Sun, 22 May 2022 06:40:54 +0000 (UTC) X-FDA: 79492431228.09.70EC648 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf22.hostedemail.com (Postfix) with ESMTP id D4DB2C0013 for ; Sun, 22 May 2022 06:40:50 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id fw21-20020a17090b129500b001df9f62edd6so8951574pjb.0 for ; Sat, 21 May 2022 23:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K7RyeoE0RrByaysSlJBBX9kNbKUMbMSMjbmqSWxbdhE=; b=ydM+bNsTqjmSr8ProqeQ1dnTvVbgtRESYlEoGN63xQ08p6qUZBZ8ARuda6R7tenlb5 PItaErd/oEcrAc1DCgdWI7LH6ZRtMNz/DoGGOCh84+YU5Q7i0ntBxSmWbmqGvHiQo/FN h55AoRHBS45cyBSEijmVnKUoUcL4U5C/Dj79OcFUeKx342ypQzsb5Tu085LObSQiPcCA 5Mr9w1rlChRajAO3QRBd2B9T1KsrlmOccEpXvsNKkp2teVj8X4ySDFtSNVCLj0Ws60ln uUlySVvdc4029NfszkZDVLIsUDDTNP7cZ4HBLJqKBMy1o5ZV3WDwHf6TyTCZBMYi34UX phbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K7RyeoE0RrByaysSlJBBX9kNbKUMbMSMjbmqSWxbdhE=; b=Ur0uVzadJG8TUcFte9rBRLJp2e4R0VjTKjIiUKgkDnaFhnKclfa4VyXE3Vq2VYwl9C X2gxYy7xMaa1eT/9pjnBqW0Po72LEBm9GwF8IZVQW4KnoHGON6dKtyPWZHScYPOP9SLJ QSjLC8aBEiXk1nFnhLYM62skz8fYHtcdkJ5zF9X7AQnldz9w4KDaDzlYvZGMfqXQ5GAx Z6w/WD+Z3ZeLDcDXUKKBD4+lNYudt4TILApB0NWS7Acnj5geRgkESb591du9AxvpBPtd jYp4RCWu5dN+kT+7S9I/nE3b6fM+H2IBjA8tBH1BoJM4vm751AM4xu+vhpKmiA5ST3d1 fUBw== X-Gm-Message-State: AOAM532pYV6jhGeaSc8WL6mbQhMl5qe9orlg5GcQHhXOPPX55m/b4f7b A8+TPxKUfnOGThnNZscW1R7o2Q== X-Google-Smtp-Source: ABdhPJwpUpul6dsTRuSMnoO0EikK7PbWaHeM6hv3oViYFnAUKrnMhYkAz5coN0WOxWiKMdvLGvDu2Q== X-Received: by 2002:a17:90a:c303:b0:1df:1ab6:68fb with SMTP id g3-20020a17090ac30300b001df1ab668fbmr19674804pjt.181.1653201652510; Sat, 21 May 2022 23:40:52 -0700 (PDT) Received: from localhost ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id e18-20020a056a0000d200b0050dc76281ecsm4633827pfj.198.2022.05.21.23.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 23:40:52 -0700 (PDT) Date: Sun, 22 May 2022 14:40:49 +0800 From: Muchun Song To: Vasily Averin Cc: Andrew Morton , kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , Michal =?iso-8859-1?Q?Koutn=FD?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org Subject: Re: [PATCH mm v2 5/9] memcg: enable accounting for percpu allocation of struct psi_group_cpu Message-ID: References: <16f17021-61a3-c6f4-f60c-1acd3a0b66b9@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16f17021-61a3-c6f4-f60c-1acd3a0b66b9@openvz.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D4DB2C0013 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=ydM+bNsT; spf=pass (imf22.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: ah18irqc4on1rd3jxyxq6b1pgp4ahca6 X-HE-Tag: 1653201650-550376 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 21, 2022 at 07:38:21PM +0300, Vasily Averin wrote: > struct pci_group_cpu is percpu allocated for each new cgroup and can > consume a significant portion of all allocated memory on nodes with > a large number of CPUs. > > Common part of the cgroup creation: > Allocs Alloc $1*$2 Sum Allocation > number size > -------------------------------------------- > 16 ~ 352 5632 5632 KERNFS > 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) > 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) > 1 192 192 10504 (__d_alloc+0x29) > 2 72 144 10648 (avc_alloc_node+0x27) > 2 64 128 10776 (percpu_ref_init+0x6a) > 1 64 64 10840 (memcg_list_lru_alloc+0x21a) > percpu: > 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e > 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f > 2 12 24 312 call_site=percpu_ref_init+0x23 > 1 6 6 318 call_site=__percpu_counter_init+0x22 > > '+' -- to be accounted, > '~' -- partially accounted > > Signed-off-by: Vasily Averin Reviewed-by: Muchun Song