From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF3EC433FE for ; Sat, 21 May 2022 04:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D05E76B0072; Sat, 21 May 2022 00:03:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDB2F6B0073; Sat, 21 May 2022 00:03:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B52FC8D0001; Sat, 21 May 2022 00:03:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 981EA6B0074 for ; Sat, 21 May 2022 00:03:11 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 66B1833260 for ; Sat, 21 May 2022 04:03:11 +0000 (UTC) X-FDA: 79488404982.27.01C1DD9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf31.hostedemail.com (Postfix) with ESMTP id B90D22001C for ; Sat, 21 May 2022 04:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jZF0dK7dSzSmSYBxZ9RlugA1Atoa9lfE0izdD/WJbmw=; b=jFnNqC//Nj0KkvYHS1hFgW7Qmg U22wqusCEoMjpN/3ap9tbz3thYYPqfEED8koY2yVDZCEFZWZoWAliJ+jD8TWjXf45LkEya0YbCMNS AWyG0ww9K1M5fpypTG3FhqJaLWbSfgZAuXRNkGtopPgyNNae2nCzvC83HFpfEk5Am2APEPYfU8MQ4 h7yiSbfFS4NDCbgwRMg6h7LavcvqOaFnqi39aoHbhzStzqEeT8v9S5YeaGvBSJQyIlYIhdV25m3ZY aYQ2ktd03i85FZ82ilHnQr5FeS59aDT/oDmixHJIZZHAbZHHtfN5RUKCi+iQohJ9Y2fMt4zM9fHTa viRouxHw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsGKB-00EMHv-3R; Sat, 21 May 2022 04:02:43 +0000 Date: Sat, 21 May 2022 05:02:43 +0100 From: Matthew Wilcox To: Chih-En Lin Cc: Andrew Morton , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Christian Brauner , Vlastimil Babka , William Kucharski , John Hubbard , Yunsheng Lin , Arnd Bergmann , Suren Baghdasaryan , Colin Cross , Feng Tang , "Eric W. Biederman" , Mike Rapoport , Geert Uytterhoeven , Anshuman Khandual , "Aneesh Kumar K.V" , Daniel Axtens , Jonathan Marek , Christophe Leroy , Pasha Tatashin , Peter Xu , Andrea Arcangeli , Thomas Gleixner , Andy Lutomirski , Sebastian Andrzej Siewior , Fenghua Yu , David Hildenbrand , linux-kernel@vger.kernel.org, Kaiyang Zhao , Huichun Feng , Jim Huang Subject: Re: [RFC PATCH 3/6] mm, pgtable: Add ownership for the PTE table Message-ID: References: <20220519183127.3909598-1-shiyn.lin@gmail.com> <20220519183127.3909598-4-shiyn.lin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220519183127.3909598-4-shiyn.lin@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: B90D22001C X-Stat-Signature: u3zqynzitkt53q5pqabigrotk17jxmfz Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="jFnNqC//"; spf=none (imf31.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-HE-Tag: 1653105759-75750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 02:31:24AM +0800, Chih-En Lin wrote: > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 8834e38c06a4..5dcbd7f6c361 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -221,6 +221,7 @@ struct page { > #ifdef LAST_CPUPID_NOT_IN_PAGE_FLAGS > int _last_cpupid; > #endif > + pmd_t *cow_pte_owner; /* cow pte: pmd */ This is definitely the wrong place. I think it could replace _pt_pad_1, since it's a pointer to a PMD and so the bottom bit will definitely be clear.