From: Roman Gushchin <roman.gushchin@linux.dev>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org, Hillf Danton <hdanton@sina.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v3 3/6] mm: shrinkers: provide shrinkers with names
Date: Fri, 20 May 2022 17:31:43 -0700 [thread overview]
Message-ID: <Yogy79yg44BX7sI1@carbon> (raw)
In-Reply-To: <20220520164115.oectf3x5hkwesioi@moria.home.lan>
On Fri, May 20, 2022 at 12:41:15PM -0400, Kent Overstreet wrote:
> On Mon, May 09, 2022 at 11:38:17AM -0700, Roman Gushchin wrote:
> > diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> > index ad9f16689419..c1f734ab86b3 100644
> > --- a/drivers/md/bcache/btree.c
> > +++ b/drivers/md/bcache/btree.c
> > @@ -812,7 +812,7 @@ int bch_btree_cache_alloc(struct cache_set *c)
> > c->shrink.seeks = 4;
> > c->shrink.batch = c->btree_pages * 2;
> >
> > - if (register_shrinker(&c->shrink))
> > + if (register_shrinker(&c->shrink, "btree"))
> > pr_warn("bcache: %s: could not register shrinker\n",
> > __func__);
>
> These drivers need better names for their shrinkers - there will often be
> multiple instances in use on a system and we need to distinguish.
>
> Also, "btree" isn't a good name for the bcache shrinker - "bcache-%pU",
> c->set_uuid would be a good name for bcache's shrinker, it'll match up with the
> cache set directory in /sys/fs/bcache/.
Sure, will improve in the next version. Thanks!
>
> For others (device mapper, md, etc.) there should be a minor device number you
> can reference.
Good point, will think of it.
Thank you for taking a look!
next prev parent reply other threads:[~2022-05-21 0:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 18:38 [PATCH v3 0/6] mm: introduce shrinker debugfs interface Roman Gushchin
2022-05-09 18:38 ` [PATCH v3 1/6] mm: memcontrol: introduce mem_cgroup_ino() and mem_cgroup_get_from_ino() Roman Gushchin
2022-05-22 7:05 ` Muchun Song
2022-05-23 18:12 ` Roman Gushchin
2022-05-24 2:00 ` Muchun Song
2022-05-09 18:38 ` [PATCH v3 2/6] mm: shrinkers: introduce debugfs interface for memory shrinkers Roman Gushchin
2022-05-20 16:45 ` Kent Overstreet
2022-05-21 0:27 ` Roman Gushchin
2022-05-20 16:58 ` Christophe JAILLET
2022-05-20 17:00 ` Kent Overstreet
2022-05-21 0:27 ` Roman Gushchin
2022-05-22 10:36 ` Muchun Song
2022-05-23 18:24 ` Roman Gushchin
2022-05-24 2:06 ` Muchun Song
2022-05-09 18:38 ` [PATCH v3 3/6] mm: shrinkers: provide shrinkers with names Roman Gushchin
2022-05-20 16:41 ` Kent Overstreet
2022-05-21 0:31 ` Roman Gushchin [this message]
2022-05-22 11:08 ` Muchun Song
2022-05-23 22:06 ` Roman Gushchin
2022-05-24 9:12 ` Muchun Song
2022-05-22 22:13 ` Dave Chinner
2022-05-24 2:18 ` Roman Gushchin
2022-05-24 23:54 ` Roman Gushchin
2022-05-09 18:38 ` [PATCH v3 4/6] mm: docs: document shrinker debugfs Roman Gushchin
2022-05-09 18:38 ` [PATCH v3 5/6] tools: add memcg_shrinker.py Roman Gushchin
2022-05-09 18:38 ` [PATCH v3 6/6] mm: shrinkers: add scan interface for shrinker debugfs Roman Gushchin
2022-05-22 11:35 ` Muchun Song
2022-05-23 20:54 ` Roman Gushchin
2022-05-24 2:23 ` Muchun Song
2022-05-19 17:15 ` [PATCH v3 0/6] mm: introduce shrinker debugfs interface Roman Gushchin
2022-05-20 4:33 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yogy79yg44BX7sI1@carbon \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dchinner@redhat.com \
--cc=hdanton@sina.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox