From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E0FC433F5 for ; Sat, 21 May 2022 00:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE4906B0072; Fri, 20 May 2022 20:27:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C92C56B0073; Fri, 20 May 2022 20:27:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5B1F8D0001; Fri, 20 May 2022 20:27:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A6D326B0072 for ; Fri, 20 May 2022 20:27:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 78724227 for ; Sat, 21 May 2022 00:27:38 +0000 (UTC) X-FDA: 79487861796.23.E97B533 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf05.hostedemail.com (Postfix) with ESMTP id 6BAFD10001E for ; Sat, 21 May 2022 00:27:12 +0000 (UTC) Date: Fri, 20 May 2022 17:27:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653092855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ybD2DLbTD497o3f+a8Ge6qsT4YJzfBUJVdSBO1Z5I2c=; b=J4JGNw8XxMYX+iMjs9avAhMHf7thryEg324HajnxGlDAo2CgNK2UEJT+kATb7Fflw0uOhj uhvuRK6Ex1GWDxQHyhYMcFVg9iyYqB18Js1SdQejp/PVaWEbIq8ey5V9kmna4Wy7M7I3Nf o1yfHDUUz0/k/n7gaNMNX4NojUokcDE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kent Overstreet Cc: Andrew Morton , linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Hillf Danton , Christophe JAILLET Subject: Re: [PATCH v3 2/6] mm: shrinkers: introduce debugfs interface for memory shrinkers Message-ID: References: <20220509183820.573666-1-roman.gushchin@linux.dev> <20220509183820.573666-3-roman.gushchin@linux.dev> <20220520164512.dqqbb5gkmfm6f4g6@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520164512.dqqbb5gkmfm6f4g6@moria.home.lan> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6BAFD10001E X-Stat-Signature: s9e75135qacg3c97ouh6eika3qxxzifi Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=J4JGNw8X; spf=pass (imf05.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-HE-Tag: 1653092832-247530 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 20, 2022 at 12:45:12PM -0400, Kent Overstreet wrote: > On Mon, May 09, 2022 at 11:38:16AM -0700, Roman Gushchin wrote: > > This commit introduces the /sys/kernel/debug/shrinker debugfs > > interface which provides an ability to observe the state of > > individual kernel memory shrinkers. > > > > Because the feature adds some memory overhead (which shouldn't be > > large unless there is a huge amount of registered shrinkers), it's > > guarded by a config option (enabled by default). > > > > This commit introduces the "count" interface for each shrinker > > registered in the system. > > > > The output is in the following format: > > ... > > ... > > ... > > > > To reduce the size of output on machines with many thousands cgroups, > > if the total number of objects on all nodes is 0, the line is omitted. > > > > If the shrinker is not memcg-aware or CONFIG_MEMCG is off, 0 is > > printed as cgroup inode id. If the shrinker is not numa-aware, 0's are > > printed for all nodes except the first one. > > > > This commit gives debugfs entries simple numeric names, which are not > > very convenient. The following commit in the series will provide > > shrinkers with more meaningful names. > > > > Signed-off-by: Roman Gushchin > > I think this looks reasonable > > Reviewed-by: Kent Overstreet Thank you!