From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A2CC433FE for ; Thu, 19 May 2022 08:19:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C0366B0072; Thu, 19 May 2022 04:19:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0743B6B0073; Thu, 19 May 2022 04:19:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA2756B0074; Thu, 19 May 2022 04:19:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DAF2A6B0072 for ; Thu, 19 May 2022 04:19:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AFD8931705 for ; Thu, 19 May 2022 08:19:43 +0000 (UTC) X-FDA: 79481793846.23.F9FE6C2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id D47F320008 for ; Thu, 19 May 2022 08:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=75wJQ7YlOANtWdF0oOc3s+1K3leawCBdFbyfjR+bGR8=; b=VWjasnU6WqmafgXhrGoXgDAg33 tiJpKj0tqkRwZseXIy3gBTxIG8oer8iAk0zvcFcKKecq4F+v/5xiUnNDpnFlZ/vG3PKd39YAFrJBM 7a2f8WkGoQ14DC1YDWdyI65XwY1WiuFUR5szqpZYPxR0weuyMCuHKWnEV3vesfkFpzfYVUDkt4tz6 Y3nbUPIbLI4WRVrtK2Whe+wtjsvauD7ZBQALbm0SpbJK4VHvuNc9B0ybQeUiBcqNTj76e1d/yegbG EjAIJTdu9B4be8neeDDYdRMmWpZZ1xcpOpBnqUVuTmnqHpE/Ld/knxOcaZCrOImIt/+C6qv5fCAJi 5RGW105Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrbNl-005lWb-1w; Thu, 19 May 2022 08:19:41 +0000 Date: Thu, 19 May 2022 01:19:41 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz Subject: Re: [RFC PATCH v3 03/18] iomap: Use iomap_page_create_gfp() in __iomap_write_begin Message-ID: References: <20220518233709.1937634-1-shr@fb.com> <20220518233709.1937634-4-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518233709.1937634-4-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D47F320008 X-Stat-Signature: xfjeyewnrqjggkp7y53pydd9kmhauuc4 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VWjasnU6; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+015a865715d1323b7cbd+6843+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+015a865715d1323b7cbd+6843+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1652948372-435567 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 18, 2022 at 04:36:54PM -0700, Stefan Roesch wrote: > This change uses the new iomap_page_create_gfp() function in the > function __iomap_write_begin(). .. and this now loses the check if we actually need the creation, see my previous comment.