From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1713CC433F5 for ; Wed, 18 May 2022 20:03:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29B136B0072; Wed, 18 May 2022 16:03:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 223356B0073; Wed, 18 May 2022 16:03:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 077FA6B0074; Wed, 18 May 2022 16:03:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EA1336B0072 for ; Wed, 18 May 2022 16:03:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BB49032A97 for ; Wed, 18 May 2022 20:03:17 +0000 (UTC) X-FDA: 79479938034.17.96F7810 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 96260400BC for ; Wed, 18 May 2022 20:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652904196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ybYz4I3r0ZirIsYrKyzXxDdd+JaWvnmVzBdQRhzjZ3E=; b=YB/RctcYqrBEPkS2MJ2xtRMEqQitMZsXiCvZw41wtbQQWr3nWB6dESkF7CF4bpEqeUm4WN YKmrZtnLghEjXTxpoCc1191acyjpHP5VAnHWVdco4/AqSFI8IXrpGFCTyzVPE/2x1YhCry YUWXKaDW/hM6IrPYTvo/4EOrkkN4qw0= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-127-Sk90PEWmODKjZ6PpJ-dklw-1; Wed, 18 May 2022 16:03:13 -0400 X-MC-Unique: Sk90PEWmODKjZ6PpJ-dklw-1 Received: by mail-io1-f69.google.com with SMTP id o4-20020a0566022e0400b0065ab2047d69so895663iow.7 for ; Wed, 18 May 2022 13:03:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ybYz4I3r0ZirIsYrKyzXxDdd+JaWvnmVzBdQRhzjZ3E=; b=Kznb1uqTeEGCgU4cEesZdVGvIjvJEOeByNNPG67yYM+pnRSPU+/+1wz2wXGY+FltA9 xDyuVOCCu3sfyCIhZzv7HIipgBo3nfn5zM3vboz57ghx8ku5Q/Ch69DWeU2kY6R8IG+M OWroeGe+ZHSJ6eo1OhXHDycTPfcXJdX7AQvSgpvIABTChSC5nU2wfQcuH+GSjL8WsXKA 6JLOwZ7n/f+oLrewvfFxT800Gb/c59xFO63qXH3Smt9JmyJGk865TxVb4GHK4PjaENup rAzGmgSXO4z2L73QfsIft6gZENoXRB+EVJfxVbp6I6wEKLOdIftbAN4Yk/nNSTGX1o5U aPtg== X-Gm-Message-State: AOAM533vmSQQ+DSdMuaWFEdrt10uxvinU1dp6Y4a/htvAt1tXxeDheBU 4rxFmJbwTQuoxpXoVecTEf7uuZT7aIWbhCdp78BWpiFMXTxQJwN9bzuXFb06GrVUVcOb+SiNSzo 1b7Zv3jxNWS4= X-Received: by 2002:a92:c6ca:0:b0:2d1:1e01:2c9 with SMTP id v10-20020a92c6ca000000b002d11e0102c9mr774583ilm.213.1652904192796; Wed, 18 May 2022 13:03:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyh67xB5wpgo0hHlt5ZET7tbWa1bzd2WnCeM//5xP6uMhS4caz3aqtq2l84xhEuUO/GiI3RmA== X-Received: by 2002:a92:c6ca:0:b0:2d1:1e01:2c9 with SMTP id v10-20020a92c6ca000000b002d11e0102c9mr774571ilm.213.1652904192600; Wed, 18 May 2022 13:03:12 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id y24-20020a5d9b18000000b0065a47e16f44sm128249ion.22.2022.05.18.13.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 13:03:11 -0700 (PDT) Date: Wed, 18 May 2022 16:03:08 -0400 From: Peter Xu To: Zach O'Keefe Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Subject: Re: [PATCH v5 02/13] mm/khugepaged: add struct collapse_control Message-ID: References: <20220504214437.2850685-1-zokeefe@google.com> <20220504214437.2850685-3-zokeefe@google.com> MIME-Version: 1.0 In-Reply-To: <20220504214437.2850685-3-zokeefe@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 96260400BC X-Stat-Signature: grqnepwfqktcjos3k9xarcgt8wdafdsd Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="YB/RctcY"; spf=none (imf12.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1652904167-351387 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 04, 2022 at 02:44:26PM -0700, Zach O'Keefe wrote: > Modularize hugepage collapse by introducing struct collapse_control. > This structure serves to describe the properties of the requested > collapse, as well as serve as a local scratch pad to use during the > collapse itself. > > Start by moving global per-node khugepaged statistics into this > new structure, and stack allocate one for khugepaged collapse > context. > > Signed-off-by: Zach O'Keefe Reviewed-by: Peter Xu There's already some UMA changes that seems to be not needed if you're going with Yang's UMA patch as pre-requisite. And I also see that there's some other changes to settle and rebase (e.g. -mm temporarily removed the khugepaged patch to move the thread around in next patch), so I figured maybe I'll just stop here and read you next version. Thanks, -- Peter Xu