From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9774C433F5 for ; Wed, 18 May 2022 16:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86E9E6B0072; Wed, 18 May 2022 12:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81E2D6B0073; Wed, 18 May 2022 12:28:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E6F06B0074; Wed, 18 May 2022 12:28:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6164E6B0072 for ; Wed, 18 May 2022 12:28:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 3BF5212059A for ; Wed, 18 May 2022 16:28:46 +0000 (UTC) X-FDA: 79479397452.10.3C70E2B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 1702D1000D7 for ; Wed, 18 May 2022 16:28:42 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF94F616AF; Wed, 18 May 2022 16:28:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88DE6C385A9; Wed, 18 May 2022 16:28:41 +0000 (UTC) Date: Wed, 18 May 2022 17:28:38 +0100 From: Catalin Marinas To: Tong Tiangen Cc: Will Deacon , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, Guohanjun , Xie XiuQi , linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH -next 2/2] arm64/mm: fix page table check compile error for CONFIG_PGTABLE_LEVELS=2 Message-ID: References: <20220517074548.2227779-1-tongtiangen@huawei.com> <20220517074548.2227779-3-tongtiangen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517074548.2227779-3-tongtiangen@huawei.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1702D1000D7 Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspam-User: X-Stat-Signature: 7b1x93by1wpfgseu4xri48wbm4t4yy7q X-HE-Tag: 1652891322-341601 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 17, 2022 at 07:45:48AM +0000, Tong Tiangen wrote: > If CONFIG_PGTABLE_LEVELS=2 and CONFIG_ARCH_SUPPORTS_PAGE_TABLE_CHECK=y, > then we trigger a compile error: > > error: implicit declaration of function 'pte_user_accessible_page' > > Move the definition of page table check helper out of branch > CONFIG_PGTABLE_LEVELS > 2 > > Fixes: daf214c14dbe ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK") > Signed-off-by: Tong Tiangen I'd drop the fixes tag here since the patch is queued in the mm tree and AFAIK that one doesn't have stable git commit ids. Otherwise: Acked-by: Catalin Marinas (I cc'ed Andrew and linux-mm as Andrew queued the original patches)