From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D5FC433EF for ; Wed, 18 May 2022 08:47:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B136C6B0074; Wed, 18 May 2022 04:47:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9BBC6B0075; Wed, 18 May 2022 04:47:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93D1E8D0002; Wed, 18 May 2022 04:47:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 81B8C6B0074 for ; Wed, 18 May 2022 04:47:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 5A6791201EF for ; Wed, 18 May 2022 08:47:11 +0000 (UTC) X-FDA: 79478234262.23.1C2B0FF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id 2C3B8C00A0 for ; Wed, 18 May 2022 08:46:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 85EE71F9AC; Wed, 18 May 2022 08:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652863626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlPkdgn8or7cOD0dFZAp9xWwMym0uxOvLKSBp6Vy4SY=; b=JWjY8wypHUQjmwOfc3uhxtY8Kaxzz5tmnZFvjQuREInRLCmnp+G6VSGeIFZcevjkw1rptv JdiZHLM8BlEEZrXEm7PyEzBNla7TLogbnkrXECeo7NtAkYiTg9A9wRB0Uu/N8zD08nEhuc zCGLDnUPfRsQyvOvbJGrSUT8JRrxZdI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652863626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlPkdgn8or7cOD0dFZAp9xWwMym0uxOvLKSBp6Vy4SY=; b=na6pnh0W5X/r+JL2Dk8w6pClreKVv6/8TAhnoyFN90NO9b8/0doTEzPvbc6QVb54Sxacgm ViG9vspk5VpjVPAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 90CB213A6D; Wed, 18 May 2022 08:47:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /kxMIIeyhGKNdQAAMHmgww (envelope-from ); Wed, 18 May 2022 08:47:03 +0000 Date: Wed, 18 May 2022 10:46:58 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, apopple@nvidia.com, david@redhat.com, surenb@google.com, peterx@redhat.com, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/15] mm/swap: use helper macro __ATTR_RW Message-ID: References: <20220509131416.17553-1-linmiaohe@huawei.com> <20220509131416.17553-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509131416.17553-3-linmiaohe@huawei.com> Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=JWjY8wyp; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=na6pnh0W; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2C3B8C00A0 X-Rspam-User: X-Stat-Signature: ndqj1yaw7qwosuuw5agzyr9nekmzjgsa X-HE-Tag: 1652863601-649063 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 09, 2022 at 09:14:03PM +0800, Miaohe Lin wrote: > Use helper macro __ATTR_RW to define vma_ra_enabled_attr to make code more > clear. Minor readability improvement. > > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador > --- > mm/swap_state.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/swap_state.c b/mm/swap_state.c > index 240b39ed5922..9f99d8137ffd 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -881,9 +881,7 @@ static ssize_t vma_ra_enabled_store(struct kobject *kobj, > > return count; > } > -static struct kobj_attribute vma_ra_enabled_attr = > - __ATTR(vma_ra_enabled, 0644, vma_ra_enabled_show, > - vma_ra_enabled_store); > +static struct kobj_attribute vma_ra_enabled_attr = __ATTR_RW(vma_ra_enabled); > > static struct attribute *swap_attrs[] = { > &vma_ra_enabled_attr.attr, > -- > 2.23.0 > > -- Oscar Salvador SUSE Labs