From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF069C433F5 for ; Wed, 18 May 2022 06:58:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12D516B0072; Wed, 18 May 2022 02:58:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DE136B0073; Wed, 18 May 2022 02:58:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35796B0074; Wed, 18 May 2022 02:58:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DBA296B0072 for ; Wed, 18 May 2022 02:58:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AFEBA60577 for ; Wed, 18 May 2022 06:58:33 +0000 (UTC) X-FDA: 79477960506.26.09E6FEA Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf13.hostedemail.com (Postfix) with ESMTP id CB076200A3 for ; Wed, 18 May 2022 06:58:10 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id i24so1298582pfa.7 for ; Tue, 17 May 2022 23:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Rd55rxMMovw1DJHwtWtEtl0R1U+oRc69yxfkFhW/hio=; b=Swbk+9Vm70BNHGqrXE4GL/6Tv578+ci1hy5+i05a8uy27qxBkTT7Ow9oHkWdZvqEUK zkzEemgm/GG5WEp8kGt6fUdTTuaAwsy6H2pxOTqcoFJVx84bTiA9yp42yD0Ibq0vbT7f JeTo8nMbZ+cbQKZOXROGFYaZV7BrO0gw4Wh+tabcZBYdD5riFl4V6OATkmHhXbtY3JU9 kytB25BnrUGasCh7tp0Al51eoNQppostiqvHjcF+ltQ9YaKw6keH8VeIBokTWGCgAIxi dziepVJjPs9Gz/1qw2g+whsJbHDOrjKe5P6NetyTc0AW/l+gSCAGP7/0I9rDwmGjp4R0 jX8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Rd55rxMMovw1DJHwtWtEtl0R1U+oRc69yxfkFhW/hio=; b=1NrbDM1JW9oqIgyHtR2QWqVK1qAh2y+Hsf1xYTv4uJ2x0fu/fMC4eC9bzHFJgAXZKa XdSVwdodvqYIKzxypK4D31+0hxQB/R7wx7u7rO7ER7LrAu5OuJh0KSQSwxS6sdLS+zQB MP/zJyQFBk3SaPYVCXIzkcDmlGNgZFC0afUASb9A4CPTuPqDrnc8n+zwxL5wnl6uI3Xz Y4gzA/E3Ej7CS5r7ppxSSldDuv9AQy3khQx9MSWzZ3viC+gqn99QAHMxgOz7RWCu/cWX zvrMC29x1Pby3rZVTOqAnaQz8IkCPH3gQkaFVG8sWKlUwtrqhPeOoefNZWWKvwkU10uM l6BQ== X-Gm-Message-State: AOAM5321e4SOrbD7WYhV5uC8hBsviAJOlAi5tX9rbpvF7OI7Q1q6G0b/ VbmmxjepCFWz5j6o+dXI15NHcAP2e1PS7w== X-Google-Smtp-Source: ABdhPJyATi7qvRbn8sZ6FiHlt7BWvwgSpx5G/qJgtKmC8fhI6KJYy8POxua/9BOMUjZtNeRI2IwDew== X-Received: by 2002:a63:4e62:0:b0:398:cb40:19b0 with SMTP id o34-20020a634e62000000b00398cb4019b0mr22631738pgl.445.1652857111880; Tue, 17 May 2022 23:58:31 -0700 (PDT) Received: from localhost ([1.157.44.177]) by smtp.gmail.com with ESMTPSA id b4-20020a170902d50400b0015f15459652sm776372plg.277.2022.05.17.23.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 23:58:30 -0700 (PDT) Date: Wed, 18 May 2022 16:58:27 +1000 From: Balbir Singh To: cgel.zte@gmail.com Cc: akpm@linux-foundation.org, ammarfaizi2@gnuweeb.org, oleksandr@natalenko.name, willy@infradead.org, linux-mm@kvack.org, corbet@lwn.net, linux-kernel@vger.kernel.org, xu xin , Yang Yang , Ran Xiaokai , wangyong , Yunkai Zhang , Jiang Xuexin Subject: Re: [PATCH] mm/ksm: introduce ksm_enabled for each process Message-ID: References: <20220517092701.1662641-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517092701.1662641-1-xu.xin16@zte.com.cn> X-Stat-Signature: r8s6j7gcajfiso73kuhbir6rp6jf4x61 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Swbk+9Vm; spf=pass (imf13.hostedemail.com: domain of bsingharora@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=bsingharora@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CB076200A3 X-HE-Tag: 1652857090-345415 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 17, 2022 at 09:27:01AM +0000, cgel.zte@gmail.com wrote: > From: xu xin > > For now, if we want to use KSM to merge pages of some apps, we have to > explicitly call madvise() in application code, which means installed > apps on OS needs to be uninstall and source code needs to be modified. > It is very inconvenient because sometimes users or app developers are not > willing to modify their app source codes for any reasons. > I thought we got process_madvise in 5.13, doesn't that help solve the problem with extensions to advice and an appropriate wrapper? Granted it might be a little racy with a running process potentially participating in KSM already. If we are concerned about KSM, I would assume that we care about long running processes, is that true? Balbir Singh