From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99913C433F5 for ; Wed, 18 May 2022 09:12:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10C436B0072; Wed, 18 May 2022 05:12:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 095406B0073; Wed, 18 May 2022 05:12:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E77226B0074; Wed, 18 May 2022 05:12:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D47646B0072 for ; Wed, 18 May 2022 05:12:16 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9978320559 for ; Wed, 18 May 2022 09:12:16 +0000 (UTC) X-FDA: 79478297472.12.8AD7E29 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 774A7200CA for ; Wed, 18 May 2022 09:11:53 +0000 (UTC) Received: by mail-wr1-f51.google.com with SMTP id r23so1780058wrr.2 for ; Wed, 18 May 2022 02:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XHuYfz9NNkR4s+xXexwOeyYdq/ChFuLByuA+gJMb9K0=; b=SOI2D2KTPeinVNm7dvpG2NkaNP1e6hqDHBnbxdsZjDvyMB+hBG8dZ51MD9aLTCG+Vz +PRbnUTdMCFcN4iJeShWWxvGvK65YNsbhNZiS25zeLE7/cP8TVOA1gDxvuv2lW5tYwmL R60jQHp5L2QCtUNSGgNjUk1/HK4wUiZPsHqlpl1X8CWnxLGQevW6bgUVYq3Viv3hsg8o 4bHFNd4K/JxxT6TQtZ3TON4n4KCkg8McbGsX/aBaCfVZ4q52w6EmoevPWck6Eaeqcj6T H3+lHeyX/rkt6XCbrj8VWcMjrHsYiur75A0I5IyM+v0PVvsqrAu5n8KucFAWe9Mbrzt7 etng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XHuYfz9NNkR4s+xXexwOeyYdq/ChFuLByuA+gJMb9K0=; b=ftiLI75OwmU0yM5LIBYsByGoItW9RQyJuY5mXoPu7N9uvyudK9pnYolmZ0BI8CS0/Z q/h+d4OcQRyP5vvx8/Bgh+NHYM4NABZBFhQ0s/aysLjBC/9SYpiFmGYMUaoATUzN+TZ3 Uf3kMYQseOdrfvCfQBMvZr7j79T8GmxF2DO3SULbKcrAxf4CRNX7CyAxdqG0EkFlYpM1 KmhmqvEhVbj7jKwKnb0bPIyZlAWZvaox3f7Ti0R1CDJyfTJOSdttd61sZeQ/e+sReY7D fqWnrmWjTPIR3LYxg308RSG5P+cr68LjdCZ9nyr4rf6t/LsIK42JbvLEQ3Zdb/H9siNg hgpQ== X-Gm-Message-State: AOAM533yi2H3xGHiWH9EbFKCz904CRs4gqE5+87toHXNuVBKoqYKmHQw cCAQOSWalIeyaN4Kgrm7KpIz/g== X-Google-Smtp-Source: ABdhPJz751lxPvBaek6HTqqBC5nl2oWm0IfqNQi8AA12TgMj102U5Lq9dmUd+bg8zCoObC2F8FxXIg== X-Received: by 2002:a5d:6791:0:b0:20d:c9f:6b00 with SMTP id v17-20020a5d6791000000b0020d0c9f6b00mr10059512wru.462.1652865134422; Wed, 18 May 2022 02:12:14 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:450f:9c92:a170:5581]) by smtp.gmail.com with ESMTPSA id y21-20020a7bcd95000000b0039489e1bbd6sm3738685wmj.47.2022.05.18.02.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 02:12:13 -0700 (PDT) Date: Wed, 18 May 2022 11:12:07 +0200 From: Marco Elver To: Jackie Liu , Andrew Morton Cc: glider@google.com, dvyukov@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH v4] mm/kfence: print disabling or re-enabling message Message-ID: References: <20220518073105.3160335-1-liu.yun@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518073105.3160335-1-liu.yun@linux.dev> User-Agent: Mutt/2.1.4 (2021-12-11) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 774A7200CA X-Stat-Signature: 7fmdputxdq7g9j6ucw98sp8nqqbo8jyz X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SOI2D2KT; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1652865113-184596 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 18, 2022 at 03:31PM +0800, Jackie Liu wrote: > From: Jackie Liu > > By printing information, we can friendly prompt the status change > information of kfence by dmesg and record by syslog. > > Also, set kfence_enabled to false only when needed. > > Co-developed-by: Marco Elver Signed-off-by: Marco Elver > Signed-off-by: Jackie Liu Reviewed-by: Marco Elver > --- > v1->v2: > fixup by Marco Elver > v2->v3: > write kfence_enabled=false only true before > v3->v4: > cleanup > > mm/kfence/core.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 11a954763be9..af0489d4d149 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -67,8 +67,11 @@ static int param_set_sample_interval(const char *val, const struct kernel_param > if (ret < 0) > return ret; > > - if (!num) /* Using 0 to indicate KFENCE is disabled. */ > + /* Using 0 to indicate KFENCE is disabled. */ > + if (!num && READ_ONCE(kfence_enabled)) { > + pr_info("disabled\n"); > WRITE_ONCE(kfence_enabled, false); > + } > > *((unsigned long *)kp->arg) = num; > > @@ -874,6 +877,7 @@ static int kfence_enable_late(void) > > WRITE_ONCE(kfence_enabled, true); > queue_delayed_work(system_unbound_wq, &kfence_timer, 0); > + pr_info("re-enabled\n"); > return 0; > } > > -- > 2.25.1 >