From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81004C433FE for ; Tue, 17 May 2022 07:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 008446B0072; Tue, 17 May 2022 03:36:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF9D96B0073; Tue, 17 May 2022 03:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC1716B0074; Tue, 17 May 2022 03:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C99856B0072 for ; Tue, 17 May 2022 03:36:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A2C1FC3B for ; Tue, 17 May 2022 07:36:57 +0000 (UTC) X-FDA: 79474428474.25.0781126 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id 3364C40096 for ; Tue, 17 May 2022 07:36:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0A34C1FBB6; Tue, 17 May 2022 07:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652773016; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5k0bGOWkmGL1ogvQ/PreqJMh1U1K6c4WBr2eA6nTSAM=; b=k1hgAxLHcPwk3vEQCWus51vT4+BvTaLYR+QHOAK3xVmdoQKgPHeTu+DfO+WesNLefN3po0 R9NLCarCPlMgTyosDYGCmIU+OFXfYoedIUeJqf22LVR7R7WTOJIFAY9q5u3r9V4b43Ynpm HwcHrcODHBHUS8nc5lhJa/98sGVBFMo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652773016; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5k0bGOWkmGL1ogvQ/PreqJMh1U1K6c4WBr2eA6nTSAM=; b=Z7Cu/hEg/PUSiAGDXraTHHfvdp/4d1ELwywNgsiUNKfH1qhjPTS9AIU7zlSRB73PQws//V lEnTbGxt5LhUgrBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B88A13305; Tue, 17 May 2022 07:36:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ueW0BpdQg2LmeQAAMHmgww (envelope-from ); Tue, 17 May 2022 07:36:55 +0000 Date: Tue, 17 May 2022 09:36:53 +0200 From: Oscar Salvador To: Muchun Song Cc: corbet@lwn.net, mike.kravetz@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, david@redhat.com, masahiroy@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v12 2/7] mm: hugetlb_vmemmap: use kstrtobool for hugetlb_vmemmap param parsing Message-ID: References: <20220516102211.41557-1-songmuchun@bytedance.com> <20220516102211.41557-3-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220516102211.41557-3-songmuchun@bytedance.com> Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=k1hgAxLH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Z7Cu/hEg"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3364C40096 X-Rspam-User: X-Stat-Signature: 5nzak1kdabm5jujgji7dco1o3bk58uyr X-HE-Tag: 1652773011-97515 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 16, 2022 at 06:22:06PM +0800, Muchun Song wrote: > Use kstrtobool rather than open coding "on" and "off" parsing in > mm/hugetlb_vmemmap.c, which is more powerful to handle all kinds > of parameters like 'Yy1Nn0' or [oO][NnFf] for "on" and "off". > > Signed-off-by: Muchun Song > Reviewed-by: Mike Kravetz > Acked-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs