From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA961C433F5 for ; Thu, 26 May 2022 10:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10D898D0003; Thu, 26 May 2022 06:50:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BFE88D0002; Thu, 26 May 2022 06:50:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEF988D0003; Thu, 26 May 2022 06:50:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E10238D0002 for ; Thu, 26 May 2022 06:50:20 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id B7CD91203A6 for ; Thu, 26 May 2022 10:50:20 +0000 (UTC) X-FDA: 79507575000.12.35856F2 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf19.hostedemail.com (Postfix) with ESMTP id C01A61A003B for ; Thu, 26 May 2022 10:50:06 +0000 (UTC) Received: by mail-io1-f47.google.com with SMTP id q203so1217275iod.0 for ; Thu, 26 May 2022 03:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TC+g0nLAl/Vtki0o8V8TPa4Q9UDxrM3TqOj5/L4+ixM=; b=YFtSfT1JENMX6vzmwrx9GUbDu6/VrDr0IVJXPX2gPnW/hjKdIBiu33pEJOVxzUsw3Q x8OLELh31z75OJ0Gr5ZVVXHB2/2YyzR17mKXIj2WitC/FOmbvyhKCbcsAnDL871UhB90 1c9fp2OQkf/e129KebQgybN3Uf+sWJu2myQSYcc+LGU45Sy4xQH5ntgeP3HOB+7lyVkZ w08YnDMYmP4ap7DT4XwMf5rlSSlldPalKvbouARLM3j7BClrRqllsKQ+d07rEwMZsAHW EQhnlZso+cIP/G8XyqToiCG3T0cYvIJEJXvlE/PWFHx9/+kCow1npxzOtkSXD89wQtbg a+kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TC+g0nLAl/Vtki0o8V8TPa4Q9UDxrM3TqOj5/L4+ixM=; b=c2zydI8zYKKMZIEzMX1I+dJ2Z0Lz0uxJNZHPu2CB9LklGrlxaKVQWh3E4r9IIwTc1a OS/TmbqBNqZs3bxojn47XCGERBre6vbl9fBs5ozJ/S4Lf+8nf3kuw7/+8zacdKfSGZdA PsHBypWAcXYwhwJIxJjuhb4HRoo+uorVgEGvpaMCJ3dt/JvLhwPNBEl44gqgrdEb0m8T 2RyC9FntDSGHP3A3CqtmN8/AEp5opxXjdPpK2IaXE9oXCqWru5+rHNrHAL4KMtG31tQw WqK1rMNlB7QGa33I10zwRuW9/qKvBjClCs5oOavh4WdW8vMgavCF4b9NRxAAY2UOocP8 tC9w== X-Gm-Message-State: AOAM530nbXD9KjATe6dxXOVbDfLgc5mTOtJiTi8PxS6HmsdDLT5L+X9b MtMPsvtR3veDn8lU1FWqt9M= X-Google-Smtp-Source: ABdhPJwUpV2a90iS2PiXgiTesfBKCL+xwb8RUX/N5sKCYXvl4cOcQJr9lDj9vqIttu3IQmrFrI3nxQ== X-Received: by 2002:a05:6638:1c13:b0:32e:c1d:a790 with SMTP id ca19-20020a0566381c1300b0032e0c1da790mr18978604jab.43.1653562219209; Thu, 26 May 2022 03:50:19 -0700 (PDT) Received: from n2.us-central1-a.c.spheric-algebra-350919.internal (151.16.70.34.bc.googleusercontent.com. [34.70.16.151]) by smtp.gmail.com with ESMTPSA id m1-20020a923f01000000b002d11397f4f9sm409593ila.74.2022.05.26.03.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 03:50:18 -0700 (PDT) Date: Thu, 26 May 2022 10:50:17 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Linus Torvalds Cc: Vlastimil Babka , David Rientjes , Joonsoo Kim , Christoph Lameter , Pekka Enberg , Andrew Morton , "linux-mm@kvack.org" , LKML , patches@lists.linux.dev, Roman Gushchin , Geert Uytterhoeven , Alexander Potapenko Subject: Re: [GIT PULL] slab for 5.19 Message-ID: References: <8062f61e-5a4d-00a5-be1a-7921d3277e9d@suse.cz> <6cdbe746-2c6f-f698-11d4-9f86d2c4e5cc@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: C01A61A003B X-Stat-Signature: 6mux8hhoba6xwny485zjc9d51yk7j3x5 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YFtSfT1J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Server: rspam04 X-HE-Tag: 1653562206-773831 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 25, 2022 at 04:07:24PM -0700, Linus Torvalds wrote: > On Wed, May 25, 2022 at 3:01 PM Vlastimil Babka wrote: > > > > Yes, running rcutorture will trigger that stackdepot allocation, but as > > that's in RCU debugging part of config, I considered it in the same > > category as enabling slub debugging. > > Yeah, I don't think rcutorture is a problem per se, it was more an > example of a random interaction that doesn't actually seem to make > much sense. Creating cache with SLAB_STORE_USER is (currently) done in rcutorture. SLAB_STORE_USER means "we're going to track every user of this slab cache" so IMO it should not be done if not debugging. Otherwise stackdepot will be used only when user passes slub_debug boot parameter. > As far as I can tell, there is nothing in rcutorture that actually > wants that stack trace, and it seems to be doing just a test of the > object dumping working. dumping an arbitrary object may call kmem_dump_obj(), which will dump slab objects and thus printing where it was allocated. > > So it was more the oddity and randomness of it that made me go > "Whaah?" There might be others hiding elsewhere, that rcutorture use > just happened to use the flag explicitly. > > Linus AFAIK only 1) creating cache with SLAB_STORE_USER or 2) passing slub_debug make kernel allocate hash table for stackdepot. This do not look that odd too me. But I agree not asking size of hash table to user and by 1) using rhashtables or 2) deciding size of hash table at runtime would be better :)