From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85529C433EF for ; Thu, 26 May 2022 01:58:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0B268D0003; Wed, 25 May 2022 21:58:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D92BE8D0001; Wed, 25 May 2022 21:58:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7BEB8D0003; Wed, 25 May 2022 21:58:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B63B38D0001 for ; Wed, 25 May 2022 21:58:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8131633EEB for ; Thu, 26 May 2022 01:58:50 +0000 (UTC) X-FDA: 79506235620.05.4292A33 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf25.hostedemail.com (Postfix) with ESMTP id 7437CA001C for ; Thu, 26 May 2022 01:58:20 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id x2-20020a17090a1f8200b001e07a64c461so3175468pja.4 for ; Wed, 25 May 2022 18:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kGL6h5v+Jr74W1Yhb+Bf5QfP2tpx/zeVbCOX59bHIDg=; b=6XMugYmG+RUzN2StHKzTsP39OPJNYLJCQObzG+2FFmneHpobDjdWIRdY3HskteR7ZQ +y9BoEU+++ihSyELnRUGFnA1pD6EW3RxiDJ3MuSe7G2PtTnSSz9kmnwqfssiHH2p8MP1 inMrblr/tC0RwZDvcfd3jiKeO7VFs9OLhILAiTiKo3dBmGwhwXkQyear1mwraKi36zNo B3vjRDg9YiY7Q1G5L370pM7cScF2zE4oRBjW7I9piLH3jWTwjNzaEqTKaD61xg3cs/lD QbrnO2HfvtvCc+K1/QIK+x85eom8nR7L9KgyQJUGz4/KGDkstI0/Ui2TwMCNdlbuVF3n EMnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kGL6h5v+Jr74W1Yhb+Bf5QfP2tpx/zeVbCOX59bHIDg=; b=vhX2jfZQKShsMwsS629Vg6TPi+rO5Jqz04n1I9MzzVWymsra5APOSaqsYzAz2uG93H uk4vidJa70jmwCe0/TM8OphhVIULzxFZedRyysnF2+DNwIKriyEhndo89F4sm5IO4/u8 hVsXPCf/Ynur6fmO5wh1xDiNXjW6KbwOHTm32frDlktnK7bOomqjJVO3ThjN7DFzSYT+ vJaEOHp3NepUcb714V4L1hjhmF/DGpHBRbyHbFdHJdipwIMS4nrInRsxEBytn1392fP3 3arDKFBsEDGlUhbl3/fPMG9WIxFBPKhJacl5F+Qy5GDelkCSQAQMc8d3hMmKtLODoP/2 60nw== X-Gm-Message-State: AOAM530eNOLHWDNGfGb7VCIe0rgyxqr2flEKvGy6ok9Lmin3XIMxVz25 bkftcSkkl2ARx3wa6cfZUX91jQ== X-Google-Smtp-Source: ABdhPJyecRSqOMMOeKI3i4gTLNfcDTqJwxnemVDUYrbKOQnvinFvVfcOT5vypfUsGRm8USrxsDh9VQ== X-Received: by 2002:a17:903:22cd:b0:161:be20:577 with SMTP id y13-20020a17090322cd00b00161be200577mr36110298plg.54.1653530328625; Wed, 25 May 2022 18:58:48 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:c40c:3e14:bb57:48be]) by smtp.gmail.com with ESMTPSA id 26-20020a63195a000000b003c6ab6ba06csm188772pgz.79.2022.05.25.18.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 18:58:48 -0700 (PDT) Date: Thu, 26 May 2022 09:58:42 +0800 From: Muchun Song To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Kent Overstreet , Hillf Danton , Christophe JAILLET Subject: Re: [PATCH v4 2/6] mm: shrinkers: introduce debugfs interface for memory shrinkers Message-ID: References: <20220525202600.2910982-1-roman.gushchin@linux.dev> <20220525202600.2910982-3-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220525202600.2910982-3-roman.gushchin@linux.dev> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7437CA001C X-Stat-Signature: d73z358wg68rqtgt6pcmrmqewmnzjkij X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=6XMugYmG; spf=pass (imf25.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1653530300-965611 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 25, 2022 at 01:25:56PM -0700, Roman Gushchin wrote: > This commit introduces the /sys/kernel/debug/shrinker debugfs > interface which provides an ability to observe the state of > individual kernel memory shrinkers. > > Because the feature adds some memory overhead (which shouldn't be > large unless there is a huge amount of registered shrinkers), it's > guarded by a config option (enabled by default). > > This commit introduces the "count" interface for each shrinker > registered in the system. > > The output is in the following format: > ... > ... > ... > > To reduce the size of output on machines with many thousands cgroups, > if the total number of objects on all nodes is 0, the line is omitted. > > If the shrinker is not memcg-aware or CONFIG_MEMCG is off, 0 is > printed as cgroup inode id. If the shrinker is not numa-aware, 0's are > printed for all nodes except the first one. > > This commit gives debugfs entries simple numeric names, which are not > very convenient. The following commit in the series will provide > shrinkers with more meaningful names. > > Signed-off-by: Roman Gushchin > Reviewed-by: Kent Overstreet Acked-by: Muchun Song Thanks.