From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72C0C433F5 for ; Wed, 25 May 2022 13:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C58C8D0005; Wed, 25 May 2022 09:25:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 273F68D0002; Wed, 25 May 2022 09:25:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15F288D0005; Wed, 25 May 2022 09:25:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 08BE18D0002 for ; Wed, 25 May 2022 09:25:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id D3CF5810F6 for ; Wed, 25 May 2022 13:25:14 +0000 (UTC) X-FDA: 79504336548.09.EC9AA83 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 7E4D74007D for ; Wed, 25 May 2022 13:25:06 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id s14so18539700plk.8 for ; Wed, 25 May 2022 06:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TKu3jDxR1qyaoZyxQd8Ts5G700gfE4pahytHEbPkEuo=; b=GXtzlSsV72DJ4r7qA3ECNDCXmSDzD8JR+b7SloEDQLdYm1Ra/ZpSJk2ACoplR9lw4J 8fqymQa/ZL0HYinpuFgcXOXxZRd/zF6n72jKlTNQRV9dpq0D6UX0i5on8X/oNtwuLC5U iIK1AyD1hM2JWl5CiM8yckZo7u1n/GdB7j5wbub/+rF3ww76dZXgPymJMPnltPFfmEZN VdpdZz/hpeiVxZRJPlgN/ztZasy+PLIfvkG2Flt3OQAQsyC9oeoKlO/F43PLMwyyQ9P+ Pp/9Nvh9eIkub2B8hVSz6WjmJmTsOHnQE4BMc+/lXsld8wAiPyWgPyTTY1qr0q/iz8vf 11tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TKu3jDxR1qyaoZyxQd8Ts5G700gfE4pahytHEbPkEuo=; b=JXQjYkEtD/Yk6Rr68+HMMrULh4QxGkffJJvL543j3/OLEuXJAc2lmpCs2Kr/F6f982 WcAqTl1/UCRzDLUIhHGnVGzKyGs9MjxqSmiG+WFQ011k2bS7nKFvuT7HeJPaCeCvorbW mhKQ7hcPzkd9R7LvEYiSmFt/rZAKedf7jqlLJ6puEnjuOodwwC9QGvO4pv4zRK2Bhub4 QGcn28xyMX0aU0x+2amV8cz2s6IIiPXrBs1tT3Ay8J7tSpqCT+Dz8kQgicR2sXZHp297 U6TI/ayuhh4jewIxLgGbrzd8Hmh8kMapJ+epVEI7fRvunTgdDL0SdeaK+5N/DEi/cbHY fvwA== X-Gm-Message-State: AOAM533SIRLtRs8QiCUL4Ahkn6hD5WkV9RYqfUIIWmXVXsfDCBAbaqxj 1KS6PCu+PcXxrXiA4OsIZ1RsGQ== X-Google-Smtp-Source: ABdhPJyN50WS/ZtJCxkiUtPA7dalNKgxc+rog0QkB9FGU0KBuqFIf2s5Rr1fKS9zMJ2Rv4ytEghz5Q== X-Received: by 2002:a17:902:eb4d:b0:15e:d25c:4e0a with SMTP id i13-20020a170902eb4d00b0015ed25c4e0amr33288707pli.8.1653485112355; Wed, 25 May 2022 06:25:12 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:c40f:7b5:4fa8:df3f]) by smtp.gmail.com with ESMTPSA id d17-20020a170903209100b0015e8e7db067sm9225346plc.4.2022.05.25.06.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 06:25:12 -0700 (PDT) Date: Wed, 25 May 2022 21:25:07 +0800 From: Muchun Song To: Baolin Wang Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte() Message-ID: References: <7cd55152c1a00910afda570d1543a97198b3665b.1653468078.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cd55152c1a00910afda570d1543a97198b3665b.1653468078.git.baolin.wang@linux.alibaba.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7E4D74007D X-Stat-Signature: e4jqgoapr5omm8888kh68hdu6ibog6za Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=GXtzlSsV; spf=pass (imf11.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-HE-Tag: 1653485106-963731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 25, 2022 at 06:26:24PM +0800, Baolin Wang wrote: > There is no need to update the hugetlb access flags after just setting the > hugetlb page table entry by set_huge_pte_at(), since the page table entry > value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags() > in hugetlb_mcopy_atomic_pte(). > > Signed-off-by: Baolin Wang Reviewed-by: Muchun Song Thanks.