From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0060DC433EF for ; Wed, 25 May 2022 11:59:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 935698D0006; Wed, 25 May 2022 07:59:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90F848D0002; Wed, 25 May 2022 07:59:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F9028D0006; Wed, 25 May 2022 07:59:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 71CD48D0002 for ; Wed, 25 May 2022 07:59:16 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4ABB91096 for ; Wed, 25 May 2022 11:59:16 +0000 (UTC) X-FDA: 79504119912.19.3D88CFE Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf19.hostedemail.com (Postfix) with ESMTP id 7AE581A0033 for ; Wed, 25 May 2022 11:59:02 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id b5so11317739plx.10 for ; Wed, 25 May 2022 04:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bBzKMMaiGL+EGEsjuc4MBX5f/qXIyEgcNNQtA6G0IvA=; b=W7qA8nhtY4E/Qs4zv/J+F2PtRVpVlxLTKZVl2y60rx5UXgTH2ir4JJQ4cbSwj/ka4Z rO3CyrijViPOhV/36HeqmSVxnym2O37IK10d0zhVBpBzZHKacaXQx1+fndmIU+betlvC iw6iu8+QfLGop+S1pacmy1CzRbKaSavv6qIFG+iLzCi0XSIRqXbUP+gXyGp+lVF+z14F 36mEXTSjCD48u0oeV8RJ8CZcOVFWI6ZF3GLUHy9XoSh8gGflwQ04Uzb8TH2aqfQtcVHZ VpUMdEQbdzBoZSc/35me/V6E0Lm1H1LFQFBqhXSgfPRuNT5CutAP7Z35vIBGkL+FLptM UD3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bBzKMMaiGL+EGEsjuc4MBX5f/qXIyEgcNNQtA6G0IvA=; b=ht4yoy2gf2a/N097dsuCZErOF0oOxdUhF59Z+vAxodPybA935fmyz4W47Y5QYhq8be zEHjZfj9E1rdIKgovNkGmJiki7bOSUjjbfQHFsw439xdmt1Zez2qVzreb4+Hzv80kviy A2Nod2MzkHYK27buYVxasWEmfydk1fM9icWk1sktaXi5hdpzcM8XBqFXNqLc06PLYaZF cbjjHneS6GWEduQ5pA57BLAqGbUqVMmc1BdE/CnqPeAhL7jFmYQTxehwP9EpFGKuuQwn SNQYmw37nrgQLe2Rd/05MhSy7PIyT4hSO2qK+rUT03W09AbzJFdgB0ULCFXO36RfgUGz qfvw== X-Gm-Message-State: AOAM5305XxgkJohQPnOgmVkkQ8H9LmMCC9WKR4dPZNAYDxbYJ7FuHhWZ tJ+YkndXEkRGzp2gAwNFhSCaCA== X-Google-Smtp-Source: ABdhPJxeRiRhJV7jRC/kDWa0f137Mc2dpQgBTgEXJ4ruDmxrqVeRSF0WsLz70rU8W/p4GmkxSZaWfw== X-Received: by 2002:a17:90a:1b4a:b0:1e0:a104:b730 with SMTP id q68-20020a17090a1b4a00b001e0a104b730mr4353940pjq.160.1653479954347; Wed, 25 May 2022 04:59:14 -0700 (PDT) Received: from localhost ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id e15-20020a17090a4a0f00b001cd4989fed3sm1424770pjh.31.2022.05.25.04.59.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 04:59:13 -0700 (PDT) Date: Wed, 25 May 2022 19:59:09 +0800 From: Muchun Song To: Johannes Weiner Cc: mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v4 10/11] mm: lru: add VM_BUG_ON_FOLIO to lru maintenance function Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-11-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7AE581A0033 X-Stat-Signature: hr135hqpn71kt4eb7ewyeuqniunfizz9 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=W7qA8nht; spf=pass (imf19.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-HE-Tag: 1653479942-562954 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 03:44:02PM -0400, Johannes Weiner wrote: > On Tue, May 24, 2022 at 02:05:50PM +0800, Muchun Song wrote: > > We need to make sure that the page is deleted from or added to the > > correct lruvec list. So add a VM_BUG_ON_FOLIO() to catch invalid > > users. > > > > Signed-off-by: Muchun Song > > Makes sense, but please use VM_WARN_ON_ONCE_FOLIO() so the machine can > continue limping along for extracting debug information. > Make sense. Will do. Thanks.