From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB88C433F5 for ; Wed, 25 May 2022 11:58:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 406D08D0003; Wed, 25 May 2022 07:58:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B2A08D0002; Wed, 25 May 2022 07:58:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29FCA8D0003; Wed, 25 May 2022 07:58:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 19D418D0002 for ; Wed, 25 May 2022 07:58:26 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id E52AD1210C6 for ; Wed, 25 May 2022 11:58:25 +0000 (UTC) X-FDA: 79504117770.29.07199BD Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 1F07A10000B for ; Wed, 25 May 2022 11:58:20 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id y1so3001441pfr.6 for ; Wed, 25 May 2022 04:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=83P9lIf96SgEF4FIz+2NIYTMoqq/3LIlBOcpNeCCdxU=; b=V9H/HXtZcLAXr098dtpBDsWTnNouWEfreWbUot8dXiLuBzVLB4mCHrI6WKX6pVyZBD kiNUVaM5D5ayScwD40y9Txc6lXPYaCgigth5ZN7Ae3+g2nfLeqXrNFEtKPGXdutjjO3n XhABixH/23MX1UYyLqe8AiN6xxOLpLYfmjfZzE4eMmEaIK+3FtTAdD/h92PM9AcDNnvv l3sS52cpVjTlm0KWQFUHr4gAgMldcOrjQLPJSBo5dCH5wXpwJDUCn8jjooO4sCA/4QAp wZktZJWFJjkaF/4ebJ6wXuCrOZYssWMh3qoqUYyRbVykBTT1PCykeNLMxk3ucGph1lD3 Oa0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=83P9lIf96SgEF4FIz+2NIYTMoqq/3LIlBOcpNeCCdxU=; b=TtBO/2GG5VLv87bXuDLj1vISBmQGfTN9bi/F58AwsdH96KVOFFPZO8/NAL5OF8NjhS 017LCifdbPYFNU913HGajJKdgmOTnxXGI2lkCYqibmk1RtkAAYGME+eIygxPQsuwTtoG TxeCrq6bWRImYXouq1b5UicGDxVHxffhYAo46R2+U/x/ze66S4X56AAyuF3tcsyBTdkQ zpuh9c2/kzFib+gs4UoZktXe9YNFIVKA/c9mRNaq+sy4YByQbzYMf51NQJsLg0InMxkR Wd2iyKTHsQa5XMzlELZvjuUi4dE/HVnrqZZEBtojgmsi55g+3VUFB43VQ5dBVRM7rjFl neGA== X-Gm-Message-State: AOAM533IoLm06+f1dNVse4t/q7Vm+Q7VUJ049gIg8Xhoed3rGGjNT13o Aa8iEcO+Q0e50xe8oYVqoH2Bfg== X-Google-Smtp-Source: ABdhPJy6C9/wlVQXBjuDdY4kOc2ORx1gRErc2TwqWFNwz6hz8oeSgI2sbVa3QRuLVigKCeQY/mA12Q== X-Received: by 2002:a62:14d2:0:b0:518:1576:65f2 with SMTP id 201-20020a6214d2000000b00518157665f2mr33285530pfu.24.1653479903310; Wed, 25 May 2022 04:58:23 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:c40f:7b5:4fa8:df3f]) by smtp.gmail.com with ESMTPSA id e24-20020a637458000000b003f5e0c264bcsm8276248pgn.66.2022.05.25.04.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 04:58:22 -0700 (PDT) Date: Wed, 25 May 2022 19:58:16 +0800 From: Muchun Song To: Roman Gushchin Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v4 10/11] mm: lru: add VM_BUG_ON_FOLIO to lru maintenance function Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-11-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 1F07A10000B X-Stat-Signature: nmaj67rqe16armwffyo4oeuksewnh63x Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="V9H/HXtZ"; spf=pass (imf14.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam03 X-HE-Tag: 1653479900-186171 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 07:40:05PM -0700, Roman Gushchin wrote: > On Tue, May 24, 2022 at 02:05:50PM +0800, Muchun Song wrote: > > We need to make sure that the page is deleted from or added to the > > correct lruvec list. So add a VM_BUG_ON_FOLIO() to catch invalid > > users. > > > > Signed-off-by: Muchun Song > > --- > > include/linux/mm_inline.h | 6 ++++++ > > mm/vmscan.c | 1 - > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > > index ac32125745ab..30d2393da613 100644 > > --- a/include/linux/mm_inline.h > > +++ b/include/linux/mm_inline.h > > @@ -97,6 +97,8 @@ void lruvec_add_folio(struct lruvec *lruvec, struct folio *folio) > > { > > enum lru_list lru = folio_lru_list(folio); > > > > + VM_BUG_ON_FOLIO(!folio_matches_lruvec(folio, lruvec), folio); > > + > > update_lru_size(lruvec, lru, folio_zonenum(folio), > > folio_nr_pages(folio)); > > if (lru != LRU_UNEVICTABLE) > > @@ -114,6 +116,8 @@ void lruvec_add_folio_tail(struct lruvec *lruvec, struct folio *folio) > > { > > enum lru_list lru = folio_lru_list(folio); > > > > + VM_BUG_ON_FOLIO(!folio_matches_lruvec(folio, lruvec), folio); > > + > > update_lru_size(lruvec, lru, folio_zonenum(folio), > > folio_nr_pages(folio)); > > /* This is not expected to be used on LRU_UNEVICTABLE */ > > @@ -131,6 +135,8 @@ void lruvec_del_folio(struct lruvec *lruvec, struct folio *folio) > > { > > enum lru_list lru = folio_lru_list(folio); > > > > + VM_BUG_ON_FOLIO(!folio_matches_lruvec(folio, lruvec), folio); > > + > > if (lru != LRU_UNEVICTABLE) > > list_del(&folio->lru); > > update_lru_size(lruvec, lru, folio_zonenum(folio), > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 761d5e0dd78d..6c9e2eafc8f9 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2281,7 +2281,6 @@ static unsigned int move_pages_to_lru(struct list_head *list) > > continue; > > } > > > > - VM_BUG_ON_PAGE(!folio_matches_lruvec(folio, lruvec), page); > > The commit log describes well why we need to add new BUG_ON's. Please, add > something on why this is removed. > OK. Will do in v5. Thanks.