From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4738EC433F5 for ; Wed, 25 May 2022 11:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FB058D0003; Wed, 25 May 2022 07:41:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AA8A8D0002; Wed, 25 May 2022 07:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BB618D0003; Wed, 25 May 2022 07:41:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 69E688D0002 for ; Wed, 25 May 2022 07:41:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 468943569F for ; Wed, 25 May 2022 11:41:33 +0000 (UTC) X-FDA: 79504075266.28.88FF2FA Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf08.hostedemail.com (Postfix) with ESMTP id 33202160002 for ; Wed, 25 May 2022 11:41:11 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id m1so18335872plx.3 for ; Wed, 25 May 2022 04:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Di7XV4IGWF77tQvxoeiNfKzeIQMl+KEXZAhavQki9xI=; b=4PIrBTtSY7gdXmJ5owF/C1/ZrJroXty20T94JZS01Q1mZd4fgW+U09Ylg34REtQHwg VvHo688nCXJo+Q7+koX9lz+0tbnGoEkPPGZ2AgZ66FiiIBz/6J2zuZ2o6ahZyYplwi5a ZpYwEegz5Et296T5u2GHEruAMZ0J0oFI2MrnGS/px1P5ZBQ3T4Fw9BIIQZ7ilJbngsZX RuccrSfBxgHlo3I+FuYajmX7kRE146DU7yk3DvUqdzSiPKw6IAB1msE3q4MepqWL+Drr HByjp0hRrmK7RyClGTppcHZFzyvg58pywiCu6oaOmRd1JgAsrEtQimpdgiRstKiuADI5 INkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Di7XV4IGWF77tQvxoeiNfKzeIQMl+KEXZAhavQki9xI=; b=uWLDFuqN4Gjs/r2ftdWGMCh81gHsFkOqwkniq03Z3gPmiWhwDL+hB0ptqKzdni1X2M lKo41RMdGjETIp6v+9nBb46usrJa+79qIc41CcYkGpkZE+AO+Pn9Tnhx/mFkvWXcFoxD uBvqBexhpHR26HfQWFIr7stJjFgii0BqTAW/GW/kIO2U9j83a8KAprqB3+tgmg6M8q5t NCUMZvyOCsQkjqbbam5gGZfZaB5JiezAqkWv43BaA8JQDA26oJLE/ksfVoc8B0YzMU3f jwxg+uJoQ0rTFIosNIE69a/vlqH1275roRy3YSBVkMO9R37B6N1j7H5oTU4Dt2q2KT+m ODNw== X-Gm-Message-State: AOAM532XyUnzcDGTKazvMyxd9/Tt2ytQLy1tzLLw1TcFx8jDhSwi3z12 jIDXe9X/4xlzPvXptp7wl63Shw== X-Google-Smtp-Source: ABdhPJz17xYLcQGQExhrQwEb4JqIELoJYEvW83JIvWk7UhoFB1UVcickRa/OeXecDgwrKutJKIJ8Fg== X-Received: by 2002:a17:902:ec85:b0:161:cff5:17c8 with SMTP id x5-20020a170902ec8500b00161cff517c8mr32385262plg.62.1653478891804; Wed, 25 May 2022 04:41:31 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:c40f:7b5:4fa8:df3f]) by smtp.gmail.com with ESMTPSA id i4-20020aa787c4000000b00518d06efbc8sm3393965pfo.98.2022.05.25.04.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 04:41:31 -0700 (PDT) Date: Wed, 25 May 2022 19:41:26 +0800 From: Muchun Song To: Roman Gushchin Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v4 04/11] mm: vmscan: rework move_pages_to_lru() Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-5-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=4PIrBTtS; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf08.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 33202160002 X-Stat-Signature: gspayexgc48xdqarwzmby791o7qtirmb X-HE-Tag: 1653478871-615054 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 07:43:03PM -0700, Roman Gushchin wrote: > On Tue, May 24, 2022 at 02:05:44PM +0800, Muchun Song wrote: > > In the later patch, we will reparent the LRU pages. The pages moved to > > appropriate LRU list can be reparented during the process of the > > move_pages_to_lru(). So holding a lruvec lock by the caller is wrong, we > > should use the more general interface of folio_lruvec_relock_irq() to > > acquire the correct lruvec lock. > > > > Signed-off-by: Muchun Song > > With changes asked by Johannes : > > Acked-by: Roman Gushchin > Thanks Roman.