From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C6CC433EF for ; Wed, 25 May 2022 02:43:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE1328D0003; Tue, 24 May 2022 22:43:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B902B8D0001; Tue, 24 May 2022 22:43:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA4458D0003; Tue, 24 May 2022 22:43:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9A9EA8D0001 for ; Tue, 24 May 2022 22:43:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 65192346D2 for ; Wed, 25 May 2022 02:43:11 +0000 (UTC) X-FDA: 79502718582.23.16414AA Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf21.hostedemail.com (Postfix) with ESMTP id 05BA21C002E for ; Wed, 25 May 2022 02:42:58 +0000 (UTC) Date: Tue, 24 May 2022 19:43:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653446588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IzX85D9y8VZc2IadwWQIPquJuvjI/THj3QAzh+7YEVk=; b=pY4AWZ78/UZn4TWf6HOYv4Shw6u6k6wcAApxRzoORivOvLOkoMivA3GRfykLZzPgLh8DwO SmjLNsvpvdP7jyPL3PYNt023IaGaHGc6ax0hkxQc26RMILhroY9sglbhEINVzQae2V70Sm bInt/T6+8/yddwoRi0/SL0OHagyEE1A= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v4 04/11] mm: vmscan: rework move_pages_to_lru() Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-5-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524060551.80037-5-songmuchun@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspamd-Queue-Id: 05BA21C002E X-Stat-Signature: r95u6sx9q3qouipbxhf1werk67zoa13k Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pY4AWZ78; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1653446578-417049 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 02:05:44PM +0800, Muchun Song wrote: > In the later patch, we will reparent the LRU pages. The pages moved to > appropriate LRU list can be reparented during the process of the > move_pages_to_lru(). So holding a lruvec lock by the caller is wrong, we > should use the more general interface of folio_lruvec_relock_irq() to > acquire the correct lruvec lock. > > Signed-off-by: Muchun Song With changes asked by Johannes : Acked-by: Roman Gushchin Thanks!