From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81973C433EF for ; Wed, 25 May 2022 02:26:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BD418D0003; Tue, 24 May 2022 22:26:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9705F8D0001; Tue, 24 May 2022 22:26:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85E0E8D0003; Tue, 24 May 2022 22:26:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7744B8D0001 for ; Tue, 24 May 2022 22:26:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 41290C6A for ; Wed, 25 May 2022 02:26:13 +0000 (UTC) X-FDA: 79502675826.27.22AF251 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf24.hostedemail.com (Postfix) with ESMTP id E14E1180002 for ; Wed, 25 May 2022 02:25:59 +0000 (UTC) Date: Tue, 24 May 2022 19:26:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653445571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eXx4F9wUjqDqnxItlogKlV+6bSU2C37UciSDkRX2OcU=; b=cltERvpd9/BsbbrUHUBYK9fauukniigpOChcjUlKIHJPRgAc6yjyz3akEdweV6Xi4OJZyj xwcrNb/oUv0hkOCAg+rPrlPKRX6J+lb11T+AN+CraLePT67cbn9CIDG/2th4mL0KM4KPah 4gjfewLE7dCTdZVEzTWN+toba5BPeQ0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Richard Palethorpe , Muhammad Usama Anjum Subject: Re: [PATCH v3 5/5] selftests: memcg: Factor out common parts of memory.{low,min} tests Message-ID: References: <20220524162955.8635-1-mkoutny@suse.com> <20220524162955.8635-6-mkoutny@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220524162955.8635-6-mkoutny@suse.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cltERvpd; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E14E1180002 X-Stat-Signature: cdjq6c644e1r5hamc3irn8miu14du3a7 X-HE-Tag: 1653445559-612398 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 06:29:55PM +0200, Michal Koutny wrote: > The memory protection test setup and runtime is almost equal for > memory.low and memory.min cases. > It makes modification of the common parts prone to mistakes, since the > protections are similar not only in setup but also in principle, factor > the common part out. > > Past exceptions between the tests: > - missing memory.min is fine (kept), > - test_memcg_low protected orphaned pagecache (adapted like > test_memcg_min and we keep the processes of protected memory running). > > The evaluation in two tests is different (OOM of allocator vs low events > of protégés), this is kept different. > > Signed-off-by: Michal Koutný Acked-by: Roman Gushchin